- Notifications
You must be signed in to change notification settings - Fork673
fix(objects): Added approval rule name to data#1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Totally missed that. Could you please format your code with black and start the commit message in present tense and small letters? Thanks 👍 |
Updating approvers new api needs a POST call. Also It needs a name of the new rule, defaulting this to 'name'.
f7130a6
to70c0cfb
Compare@max-wittig All fixed! |
@charlesfayal Sorry for the delay, but I think there is a small copy paste error |
@@ -2707,12 +2707,13 @@ def set_approvers( | |||
self._parent.get_id(), | |||
) | |||
data = { | |||
"approvals_required": approvals_required, | |||
"name": "name", | |||
"self.assertEqual(expected, actual, 'message')pprovals_required": approvals_required, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This doesn't look right
The new gitlab api needs a name for the approval rules, added a default one to maintain the python-gitlab api.
The prior pull request wasn't ready for merge, needed this fix.