Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add capability to control GitLab features per project or group#1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

filipowm
Copy link
Contributor

@filipowmfilipowm commentedFeb 5, 2020•
edited
Loading

Currently GitLab Features API supports configuring features not only globally or per user, but also per group or project.python-gitlab is currently missing this option, thus this PR.

Additionally fixed issue when setting up feature withNone(null) values, e.g. nonefeature_group oruser. It caused GitLab to respond with HTTP 500. Thus now we're filtering outNone values from data.

@filipowmfilipowmforce-pushed thefeature/feature-flags-additional-config branch 2 times, most recently from4f4c4ef to739666fCompareFebruary 5, 2020 13:27
@filipowm
Copy link
ContributorAuthor

@max-wittig Could you please take a look?
This one is currently blocking PR in gitlab configuration-as-code tool:Roche/gitlab-configuration-as-code#11

@max-wittig
Copy link
Member

@filipowm Thanks for the MR. Could you please drop the duplicate commits from master and rebase instead?

filipowm reacted with thumbs up emoji

@filipowmfilipowmforce-pushed thefeature/feature-flags-additional-config branch fromad2ed38 to1ec1816CompareFebruary 7, 2020 10:00
@filipowm
Copy link
ContributorAuthor

@filipowm Thanks for the MR. Could you please drop the duplicate commits from master and rebase instead?

Done. I missed to notice that :)

@max-wittigmax-wittig merged commit066fc9b intopython-gitlab:masterFeb 10, 2020
@max-wittig
Copy link
Member

@filipowm Thanks for your efforts!

@filipowmfilipowm deleted the feature/feature-flags-additional-config branchFebruary 14, 2020 07:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@max-wittigmax-wittigmax-wittig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@filipowm@max-wittig
[8]ページ先頭
©2009-2025 Movatter.jp