- Notifications
You must be signed in to change notification settings - Fork673
change path for set_approvers to new api, with defaulted rule_type an…#1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@charlesfayal Thanks for the MR! Could you please also update the documentation and the tests? |
a0481f9 tofd5c24eCompareUpdated the gitlab path for set_approvers to approvers_rules, added default arg for rule type, and added arg for # of approvals required.
Updated the docs with the new set_approvers arguments, and updated tests with the arg as well.
Added a miss paramter update to the set_approvers function
to set the # of approvers for an MR you need to use the same function as for setting the approvers id.
fd5c24e to8e0c526Compare@max-wittig how's that? |
@max-wittig Im a little confused how to test this manually. How can I build the python projection into an importable project to test in my own project? |
@charlesfayal You can just install the wheel with pip |
@charlesfayal Just report back, when I should take a look |
@charlesfayal Thanks for the MR! |
…d added args for approvals_required