Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make tests so that will not be impacted by any existing config files #2177

Closed
Labels
testFor issues or missing tests
@JohnVillalovos

Description

@JohnVillalovos

Capturing the comments that were left by@nejch in#2173

Thanks for the catch@JohnVillalovos! We already have some scaffolding for mocking/prepping a clean config environment but perhaps it was not broad enough in where we placed it. It seems we should have a clean environment forall tests by adding that to the roottests/conftest.py e.g.:

  1. Move thismock_clean_env fixture to the root conftest withautouse=True - no testever should break from a user-suppliedPYTHON_GITLAB_CFG:

    @pytest.fixture
    defmock_clean_env(monkeypatch):
    monkeypatch.delenv("PYTHON_GITLAB_CFG",raising=False)

  2. Move more logic to that fixture that we already use to ensure an empty list of default files - same here, no testever should be affected by presence of local files:

    withmonkeypatch.context()asm:
    m.setattr(config,"_DEFAULT_FILES", [])

  3. In any test that does specifically need that, override it again if needed (I think we mostly don't, as we explicitly define things) like we already do here:

    monkeypatch.setenv("PYTHON_GITLAB_CFG","/some/path")

More approaches are discussed herehttps://stackoverflow.com/questions/38748257/disable-autouse-fixtures-on-specific-pytest-marks in case the simple override is not enough.

WDYT? This would then also be more local/CI-agnostic and consistent across all runs and we can stop worrying about config even before we hit CI.

Metadata

Metadata

Assignees

No one assigned

    Labels

    testFor issues or missing tests

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp