Commitffdef9b

committed

chore(topics): 'title' is required when creating a topic

1 parent69014e9 commitffdef9bCopy full SHA for ffdef9b

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ class TopicManager(CRUDMixin, RESTManager):`
`19`	`19`	`_path="/topics"`
`20`	`20`	`_obj_cls=Topic`
`21`	`21`	`_create_attrs=RequiredOptional(`
`22`		`-required=("name",),optional=("avatar","description")`
	`22`	`+required=("name","title"),optional=("avatar","description")`
`23`	`23`	`)`
`24`	`24`	`_update_attrs=RequiredOptional(optional=("avatar","description","name"))`
`25`	`25`	`_types= {"avatar":types.ImageAttribute}`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,11 @@`
`7`	`7`	`deftest_topics(gl):`
`8`	`8`	`assertnotgl.topics.list()`
`9`	`9`
`10`		`-topic=gl.topics.create({"name":"my-topic","description":"My Topic"})`
	`10`	`+topic=gl.topics.create(`
	`11`	`+ {"name":"my-topic","title":"my topic title","description":"My Topic"}`
	`12`	`+ )`
`11`	`13`	`asserttopic.name=="my-topic"`
	`14`	`+asserttopic.title=="my topic title"`
`12`	`15`	`assertgl.topics.list()`
`13`	`16`
`14`	`17`	`topic.description="My Updated Topic"`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,10 +8,12 @@`
`8`	`8`	`fromgitlab.v4.objectsimportTopic`
`9`	`9`
`10`	`10`	`name="GitLab"`
	`11`	`+topic_title="topic title"`
`11`	`12`	`new_name="gitlab-test"`
`12`	`13`	`topic_content= {`
`13`	`14`	`"id":1,`
`14`	`15`	`"name":name,`
	`16`	`+"title":topic_title,`
`15`	`17`	`"description":"GitLab is an open source end-to-end software development platform.",`
`16`	`18`	`"total_projects_count":1000,`
`17`	`19`	`"avatar_url":"http://www.gravatar.com/avatar/a0d477b3ea21970ce6ffcbb817b0b435?s=80&d=identicon",`
`@@ -102,9 +104,10 @@ def test_get_topic(gl, resp_get_topic):`
`102`	`104`
`103`	`105`
`104`	`106`	`deftest_create_topic(gl,resp_create_topic):`
`105`		`-topic=gl.topics.create({"name":name})`
	`107`	`+topic=gl.topics.create({"name":name,"title":topic_title})`
`106`	`108`	`assertisinstance(topic,Topic)`
`107`	`109`	`asserttopic.name==name`
	`110`	`+asserttopic.title==topic_title`
`108`	`111`
`109`	`112`
`110`	`113`	`deftest_update_topic(gl,resp_update_topic):`

Comments

(0)