Commitfddc25a

authored

Merge pull request#919 from appian/project-approval-rules

fix(projects): support `approval_rules` endpoint for projects

2 parents6048175 +94bac44 commitfddc25aCopy full SHA for fddc25a

File tree

+45

-0

lines changed

+45

-0

lines changed

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,8 @@ References`
`12`	`12`
`13`	`13`	+:class:`gitlab.v4.objects.ProjectApproval`
`14`	`14`	+:class:`gitlab.v4.objects.ProjectApprovalManager`
	`15`	+ +:class:`gitlab.v4.objects.ProjectApprovalRule`
	`16`	+ +:class:`gitlab.v4.objects.ProjectApprovalRuleManager`
`15`	`17`	+:attr:`gitlab.v4.objects.Project.approvals`
`16`	`18`	+:class:`gitlab.v4.objects.ProjectMergeRequestApproval`
`17`	`19`	+:class:`gitlab.v4.objects.ProjectMergeRequestApprovalManager`
`@@ -22,6 +24,19 @@ References`
`22`	`24`	`Examples`
`23`	`25`	`--------`
`24`	`26`
	`27`	`+List project-level MR approval rules::`
	`28`	`+`
	`29`	`+ p_mras = project.approvalrules.list()`
	`30`	`+`
	`31`	`+Change project-level MR approval rule::`
	`32`	`+`
	`33`	`+ p_approvalrule.user_ids = [234]`
	`34`	`+ p_approvalrule.save()`
	`35`	`+`
	`36`	`+Delete project-level MR approval rule::`
	`37`	`+`
	`38`	`+ p_approvalrule.delete()`
	`39`	`+`
`25`	`40`	`Get project-level or MR-level MR approvals settings::`
`26`	`41`
`27`	`42`	`p_mras = project.approvals.get()`

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3777,6 +3777,19 @@ def set_approvers(self, approver_ids=None, approver_group_ids=None, **kwargs):`
`3777`	`3777`	`self.gitlab.http_put(path,post_data=data,**kwargs)`
`3778`	`3778`
`3779`	`3779`
	`3780`	`+classProjectApprovalRule(SaveMixin,ObjectDeleteMixin,RESTObject):`
	`3781`	`+_id_attr="id"`
	`3782`	`+`
	`3783`	`+`
	`3784`	`+classProjectApprovalRuleManager(`
	`3785`	`+ListMixin,CreateMixin,UpdateMixin,DeleteMixin,RESTManager`
	`3786`	`+):`
	`3787`	`+_path="/projects/%(project_id)s/approval_rules"`
	`3788`	`+_obj_cls=ProjectApprovalRule`
	`3789`	`+_from_parent_attrs= {"project_id":"id"}`
	`3790`	`+_create_attrs= (("name","approvals_required"), ("user_ids","group_ids"))`
	`3791`	`+`
	`3792`	`+`
`3780`	`3793`	`classProjectDeployment(RESTObject,SaveMixin):`
`3781`	`3794`	`pass`
`3782`	`3795`
`@@ -3888,6 +3901,7 @@ class Project(SaveMixin, ObjectDeleteMixin, RESTObject):`
`3888`	`3901`	`_managers= (`
`3889`	`3902`	`("accessrequests","ProjectAccessRequestManager"),`
`3890`	`3903`	`("approvals","ProjectApprovalManager"),`
	`3904`	`+ ("approvalrules","ProjectApprovalRuleManager"),`
`3891`	`3905`	`("badges","ProjectBadgeManager"),`
`3892`	`3906`	`("boards","ProjectBoardManager"),`
`3893`	`3907`	`("branches","ProjectBranchManager"),`

Lines changed: 16 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,22 @@ def end_log():`
`53`	`53`	`mr.approvals.set_approvers([1], [])`
`54`	`54`	`approval=mr.approvals.get()`
`55`	`55`	`assertapproval.approvers[0]["user"]["id"]==1`
	`56`	`+`
	`57`	`+ars=project1.approvalrules.list(all=True)`
	`58`	`+assertlen(ars)==0`
	`59`	`+project.approvalrules.create(`
	`60`	`+ {"name":"approval-rule","approvals_required":1,"group_ids": [group1.id]}`
	`61`	`+)`
	`62`	`+ars=project1.approvalrules.list(all=True)`
	`63`	`+assertlen(ars)==1`
	`64`	`+ars[0].approvals_required==2`
	`65`	`+ars[0].save()`
	`66`	`+ars=project1.approvalrules.list(all=True)`
	`67`	`+assertlen(ars)==1`
	`68`	`+assertars[0].approvals_required==2`
	`69`	`+ars[0].delete()`
	`70`	`+ars=project1.approvalrules.list(all=True)`
	`71`	`+assertlen(ars)==0`
`56`	`72`	`end_log()`
`57`	`73`
`58`	`74`	`start_log("geo nodes")`

Comments

(0)