Commitf98fd90

committed

style: recommended changes in PR review

1 parent919440b commitf98fd90Copy full SHA for f98fd90

File tree

-5

lines changed

-5

lines changed

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -342,10 +342,9 @@ def update(`
`342`	`342`	`else:`
`343`	`343`	`path=f"{self.path}/{utils.EncodedId(id)}"`
`344`	`344`
`345`		`-ifself._obj_clsisnotNone:`
	`345`	`+excludes= []`
	`346`	`+ifself._obj_clsisnotNoneandself._obj_cls._id_attrisnotNone:`
`346`	`347`	`excludes= [self._obj_cls._id_attr]`
`347`		`-else:`
`348`		`-excludes=None`
`349`	`348`	`utils._validate_attrs(`
`350`	`349`	`data=new_data,attributes=self._update_attrs,excludes=excludes`
`351`	`350`	`)`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`importtraceback`
`20`	`20`	`importurllib.parse`
`21`	`21`	`importwarnings`
`22`		`-fromtypingimportAny,Callable,Dict,Optional,Tuple,Type,Union`
	`22`	`+fromtypingimportAny,Callable,Dict,List,Optional,Tuple,Type,Union`
`23`	`23`
`24`	`24`	`importrequests`
`25`	`25`
`@@ -166,7 +166,7 @@ def warn(`
`166`	`166`	`def_validate_attrs(`
`167`	`167`	`data:Dict[str,Any],`
`168`	`168`	`attributes:types.RequiredOptional,`
`169`		`-excludes:Optional[list]=None,`
	`169`	`+excludes:Optional[List[str]]=None,`
`170`	`170`	`)->None:`
`171`	`171`	`ifexcludesisNone:`
`172`	`172`	`excludes= []`

Comments

(0)