Commitef8f0e1

JohnVillalovos

authored and

nejch

committed

fix: handle large number of approval rules

Use `iterator=True` when going through the list of current approvalrules. This allows it to handle more than the default of 20 approvalrules.Closes:#2825

1 parent33fbc14 commitef8f0e1Copy full SHA for ef8f0e1

File tree

1 file changed

-1

lines changed

gitlab/v4/objects
- merge_request_approvals.py

1 file changed

-1

lines changed

`‎gitlab/v4/objects/merge_request_approvals.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ def set_approvers(`
`122`	`122`	`self._parent.approval_rules`
`123`	`123`	`)`
`124`	`124`	`# update any existing approval rule matching the name`
`125`		`-existing_approval_rules=approval_rules.list()`
	`125`	`+existing_approval_rules=approval_rules.list(iterator=True)`
`126`	`126`	`forarinexisting_approval_rules:`
`127`	`127`	`ifar.name==approval_rule_name:`
`128`	`128`	`ar.user_ids=data["user_ids"]`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitef8f0e1

File tree

1 file changed

1 file changed

`‎gitlab/v4/objects/merge_request_approvals.py`

0 commit comments