Commite3035a7

nejch

authored and

JohnVillalovos

committed

chore(api): temporarily remove topic delete endpoint

It is not yet available upstream.

1 parent49af15b commite3035a7Copy full SHA for e3035a7

File tree

5 files changed

-33

lines changed

docs/gl_objects
- topics.rst
gitlab/v4/objects
- topics.py
tests
- functional
  - api
    - test_topics.py
  - conftest.py
- unit/objects
  - test_topics.py

5 files changed

-33

lines changed

`‎docs/gl_objects/topics.rst`

Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,10 +39,3 @@ Update a topic::`
`39`	`39`
`40`	`40`	`# or`
`41`	`41`	`gl.topics.update(topic_id, {"description": "My new topic"})`
`42`		`-`
`43`		`-Delete a topic::`
`44`		`-`
`45`		`- topic.delete()`
`46`		`-`
`47`		`- # or`
`48`		`- gl.topics.delete(topic_id)`

`‎gitlab/v4/objects/topics.py`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,19 +2,19 @@`
`2`	`2`
`3`	`3`	`fromgitlabimporttypes`
`4`	`4`	`fromgitlab.baseimportRequiredOptional,RESTManager,RESTObject`
`5`		`-fromgitlab.mixinsimportCRUDMixin,ObjectDeleteMixin,SaveMixin`
	`5`	`+fromgitlab.mixinsimportCreateMixin,RetrieveMixin,SaveMixin,UpdateMixin`
`6`	`6`
`7`	`7`	`__all__= [`
`8`	`8`	`"Topic",`
`9`	`9`	`"TopicManager",`
`10`	`10`	`]`
`11`	`11`
`12`	`12`
`13`		`-classTopic(SaveMixin,ObjectDeleteMixin,RESTObject):`
	`13`	`+classTopic(SaveMixin,RESTObject):`
`14`	`14`	`pass`
`15`	`15`
`16`	`16`
`17`		`-classTopicManager(CRUDMixin,RESTManager):`
	`17`	`+classTopicManager(CreateMixin,RetrieveMixin,UpdateMixin,RESTManager):`
`18`	`18`	`_path="/topics"`
`19`	`19`	`_obj_cls=Topic`
`20`	`20`	`_create_attrs=RequiredOptional(`

`‎tests/functional/api/test_topics.py`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,3 @@ def test_topics(gl):`
`16`	`16`
`17`	`17`	`updated_topic=gl.topics.get(topic.id)`
`18`	`18`	`assertupdated_topic.description==topic.description`
`19`		`-`
`20`		`-topic.delete()`
`21`		`-assertnotgl.topics.list()`

`‎tests/functional/conftest.py`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,6 @@ def reset_gitlab(gl):`
`24`	`24`	`fordeploy_tokeningroup.deploytokens.list():`
`25`	`25`	`deploy_token.delete()`
`26`	`26`	`group.delete()`
`27`		`-fortopicingl.topics.list():`
`28`		`-topic.delete()`
`29`	`27`	`forvariableingl.variables.list():`
`30`	`28`	`variable.delete()`
`31`	`29`	`foruseringl.users.list():`

`‎tests/unit/objects/test_topics.py`

Lines changed: 0 additions & 18 deletions

Original file line number	Diff line number	Diff line change
`@@ -75,19 +75,6 @@ def resp_update_topic():`
`75`	`75`	`yieldrsps`
`76`	`76`
`77`	`77`
`78`		`-@pytest.fixture`
`79`		`-defresp_delete_topic(no_content):`
`80`		`-withresponses.RequestsMock()asrsps:`
`81`		`-rsps.add(`
`82`		`-method=responses.DELETE,`
`83`		`-url=topic_url,`
`84`		`-json=no_content,`
`85`		`-content_type="application/json",`
`86`		`-status=204,`
`87`		`- )`
`88`		`-yieldrsps`
`89`		`-`
`90`		`-`
`91`	`78`	`deftest_list_topics(gl,resp_list_topics):`
`92`	`79`	`topics=gl.topics.list()`
`93`	`80`	`assertisinstance(topics,list)`
`@@ -112,8 +99,3 @@ def test_update_topic(gl, resp_update_topic):`
`112`	`99`	`topic.name=new_name`
`113`	`100`	`topic.save()`
`114`	`101`	`asserttopic.name==new_name`
`115`		`-`
`116`		`-`
`117`		`-deftest_delete_topic(gl,resp_delete_topic):`
`118`		`-topic=gl.topics.get(1,lazy=True)`
`119`		`-topic.delete()`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite3035a7

File tree

5 files changed

5 files changed

`‎docs/gl_objects/topics.rst`

`‎gitlab/v4/objects/topics.py`

`‎tests/functional/api/test_topics.py`

`‎tests/functional/conftest.py`

`‎tests/unit/objects/test_topics.py`

0 commit comments