Commitdc32d54

authored and

committed

chore: consistently use open() encoding and file descriptor

1 parent618267c commitdc32d54Copy full SHA for dc32d54

File tree

-9

lines changed

-9

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -257,8 +257,8 @@ def _parse_value(v: Any) -> Any:`
`257`	`257`	`# If the user-provided value starts with @, we try to read the file`
`258`	`258`	`# path provided after @ as the real value. Exit on any error.`
`259`	`259`	`try:`
`260`		`-withopen(v[1:])asfl:`
`261`		`-returnfl.read()`
	`260`	`+withopen(v[1:])asf:`
	`261`	`+returnf.read()`
`262`	`262`	`exceptExceptionase:`
`263`	`263`	`sys.stderr.write(f"{e}\n")`
`264`	`264`	`sys.exit(1)`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,16 +6,16 @@`
`6`	`6`
`7`	`7`	`defget_version()->str:`
`8`	`8`	`version=""`
`9`		`-withopen("gitlab/_version.py")asf:`
	`9`	`+withopen("gitlab/_version.py","r",encoding="utf-8")asf:`
`10`	`10`	`forlineinf:`
`11`	`11`	`ifline.startswith("__version__"):`
`12`	`12`	`version=eval(line.split("=")[-1])`
`13`	`13`	`break`
`14`	`14`	`returnversion`
`15`	`15`
`16`	`16`
`17`		`-withopen("README.rst","r")asreadme_file:`
`18`		`-readme=readme_file.read()`
	`17`	`+withopen("README.rst","r",encoding="utf-8")asf:`
	`18`	`+readme=f.read()`
`19`	`19`
`20`	`20`	`setup(`
`21`	`21`	`name="python-gitlab",`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ def set_token(container, fixture_dir):`
`87`	`87`	`logging.info("Creating API token.")`
`88`	`88`	`set_token_rb=fixture_dir/"set_token.rb"`
`89`	`89`
`90`		`-withopen(set_token_rb,"r")asf:`
	`90`	`+withopen(set_token_rb,"r",encoding="utf-8")asf:`
`91`	`91`	`set_token_command=f.read().strip()`
`92`	`92`
`93`	`93`	`rails_command= [`
`@@ -206,7 +206,7 @@ def gitlab_config(check_is_alive, docker_ip, docker_services, temp_dir, fixture_`
`206`	`206`	`private_token ={token}`
`207`	`207`	`api_version = 4"""`
`208`	`208`
`209`		`-withopen(config_file,"w")asf:`
	`209`	`+withopen(config_file,"w",encoding="utf-8")asf:`
`210`	`210`	`f.write(config)`
`211`	`211`
`212`	`212`	`returnconfig_file`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,8 @@`
`12`	`12`
`13`	`13`	`@pytest.fixture()`
`14`	`14`	`defjson_content(fixture_dir):`
`15`		`-withopen(fixture_dir/"todo.json","r")asjson_file:`
`16`		`-todo_content=json_file.read()`
	`15`	`+withopen(fixture_dir/"todo.json","r",encoding="utf-8")asf:`
	`16`	`+todo_content=f.read()`
`17`	`17`	`returnjson.loads(todo_content)`
`18`	`18`
`19`	`19`

Comments

(0)