NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

Commitcb6a3c6

committed

fix: change mr.merge() to use 'post_data'

MR#1121 changedmr.merge() to use 'query_data'. This appears to have been wrong.From the Gitlab docs they state it should be sent in a payload bodyhttps://docs.gitlab.com/ee/api/README.html#request-payload sincemr.merge() is a PUT request. > Request Payload > API Requests can use parameters sent as query strings or as a > payload body. GET requests usually send a query string, while PUT > or POST requests usually send the payload bodyFixes:#1452Related to:#1120

1 parentcd5993c commitcb6a3c6Copy full SHA for cb6a3c6

File tree

1 file changed

-1

lines changed

gitlab/v4/objects
- merge_requests.py

1 file changed

-1

lines changed

`‎gitlab/v4/objects/merge_requests.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,7 @@ def merge(`
`342`	`342`	`ifmerge_when_pipeline_succeeds:`
`343`	`343`	`data["merge_when_pipeline_succeeds"]=True`
`344`	`344`
`345`		`-server_data=self.manager.gitlab.http_put(path,query_data=data,**kwargs)`
	`345`	`+server_data=self.manager.gitlab.http_put(path,post_data=data,**kwargs)`
`346`	`346`	`self._update_attrs(server_data)`
`347`	`347`
`348`	`348`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitcb6a3c6

File tree

1 file changed

1 file changed

`‎gitlab/v4/objects/merge_requests.py`

0 commit comments