Commitca37d23

authored

Merge pull request#1038 from nejch/fix/allow-empty-create-data

Fix: do not require empty data dict for create()

2 parentse5afb55 +99d959f commitca37d23Copy full SHA for ca37d23

File tree

-6

lines changed

-6

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,8 @@ List access requests from projects and groups::`
`37`	`37`
`38`	`38`	`Create an access request::`
`39`	`39`
`40`		`- p_ar = project.accessrequests.create({})`
`41`		`- g_ar = group.accessrequests.create({})`
	`40`	`+ p_ar = project.accessrequests.create()`
	`41`	`+ g_ar = group.accessrequests.create()`
`42`	`42`
`43`	`43`	`Approve an access request::`
`44`	`44`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ Delete a project::`
`103`	`103`
`104`	`104`	`Fork a project::`
`105`	`105`
`106`		`- fork = project.forks.create({})`
	`106`	`+ fork = project.forks.create()`
`107`	`107`
`108`	`108`	`# fork to a specific namespace`
`109`	`109`	`fork = project.forks.create({'namespace': 'myteam'})`
`@@ -255,7 +255,7 @@ generated by GitLab you need to:`
`255`	`255`
`256`	`256`	`# Create the export`
`257`	`257`	`p = gl.projects.get(my_project)`
`258`		`- export = p.exports.create({})`
	`258`	`+ export = p.exports.create()`
`259`	`259`
`260`	`260`	`# Wait for the 'finished' status`
`261`	`261`	`export.refresh()`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ def get_create_attrs(self):`
`170`	`170`	`returngetattr(self,"_create_attrs", (tuple(),tuple()))`
`171`	`171`
`172`	`172`	`@exc.on_http_error(exc.GitlabCreateError)`
`173`		`-defcreate(self,data,**kwargs):`
	`173`	`+defcreate(self,data=None,**kwargs):`
`174`	`174`	`"""Create a new object.`
`175`	`175`
`176`	`176`	`Args:`
`@@ -186,6 +186,9 @@ def create(self, data, **kwargs):`
`186`	`186`	`GitlabAuthenticationError: If authentication is not correct`
`187`	`187`	`GitlabCreateError: If the server cannot perform the request`
`188`	`188`	`"""`
	`189`	`+ifdataisNone:`
	`190`	`+data= {}`
	`191`	`+`
`189`	`192`	`self._check_missing_create_attrs(data)`
`190`	`193`	`files= {}`
`191`	`194`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -949,7 +949,7 @@`
`949`	`949`	`[current_project.delete()forcurrent_projectinprojects]`
`950`	`950`
`951`	`951`	`# project import/export`
`952`		`-ex=admin_project.exports.create({})`
	`952`	`+ex=admin_project.exports.create()`
`953`	`953`	`ex.refresh()`
`954`	`954`	`count=0`
`955`	`955`	`whileex.export_status!="finished":`

Comments

(0)