Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitb981ce7

Browse files
chore: renamegitlab/__version__.py ->gitlab/_version.py
It is confusing to have a `gitlab/__version__.py` because we alsocreate a variable `gitlab.__version__` which can conflict with`gitlab/__version__.py`.For example in `gitlab/const.py` we have to know that`gitlab.__version__` is a module and not the variable due to theordering of imports. But in most other usage `gitlab.__version__` is aversion string.To reduce confusion make the name of the version file`gitlab/_version.py`.
1 parentcbbe7ce commitb981ce7

File tree

7 files changed

+6
-6
lines changed

7 files changed

+6
-6
lines changed

‎CONTRIBUTING.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ This avoids triggering incorrect version bumps and releases without functional c
153153
The release workflow uses `python-semantic-release
154154
<https://python-semantic-release.readthedocs.io>`_ and does the following:
155155

156-
* Bumps the version in ``__version__.py`` and adds an entry in ``CHANGELOG.md``,
156+
* Bumps the version in ``_version.py`` and adds an entry in ``CHANGELOG.md``,
157157
* Commits and tags the changes, then pushes to the main branch as the ``github-actions`` user,
158158
* Creates a release from the tag and adds the changelog entry to the release notes,
159159
* Uploads the package as assets to the GitHub release,

‎gitlab/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
fromtypingimportAny
2121

2222
importgitlab.config# noqa: F401
23-
fromgitlab.__version__import (# noqa: F401
23+
fromgitlab._versionimport (# noqa: F401
2424
__author__,
2525
__copyright__,
2626
__email__,
File renamed without changes.

‎gitlab/const.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# You should have received a copy of the GNU Lesser General Public License
1616
# along with this program. If not, see <http://www.gnu.org/licenses/>.
1717

18-
fromgitlab.__version__import__title__,__version__
18+
fromgitlab._versionimport__title__,__version__
1919

2020
# NOTE(jlvillal): '_DEPRECATED' only affects users accessing constants via the
2121
# top-level gitlab.* namespace. See 'gitlab/__init__.py:__getattr__()' for the

‎pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ ignore_errors = true
3838

3939
[tool.semantic_release]
4040
branch ="main"
41-
version_variable ="gitlab/__version__.py:__version__"
41+
version_variable ="gitlab/_version.py:__version__"
4242
commit_subject ="chore: release v{version}"
4343
commit_message =""
4444

‎setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
defget_version()->str:
88
version=""
9-
withopen("gitlab/__version__.py")asf:
9+
withopen("gitlab/_version.py")asf:
1010
forlineinf:
1111
ifline.startswith("__version__"):
1212
version=eval(line.split("=")[-1])

‎tests/smoke/test_dists.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
importpytest
77
fromsetuptoolsimportsandbox
88

9-
fromgitlabimport__title__,__version__
9+
fromgitlab._versionimport__title__,__version__
1010

1111
DIST_DIR=Path("dist")
1212
DOCS_DIR="docs"

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp