Commitaf965d4

authored

Merge pull request#1213 from python-gitlab/fix/delete-attr

fix(base): really refresh object

2 parentsce8460f +e1e0d8c commitaf965d4Copy full SHA for af965d4

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ def _create_managers(self):`
`131`	`131`
`132`	`132`	`def_update_attrs(self,new_attrs):`
`133`	`133`	`self.__dict__["_updated_attrs"]= {}`
`134`		`-self.__dict__["_attrs"].update(new_attrs)`
	`134`	`+self.__dict__["_attrs"]=new_attrs`
`135`	`135`
`136`	`136`	`defget_id(self):`
`137`	`137`	`"""Returns the id of the resource."""`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,13 @@ def test_update_attrs(self, fake_manager):`
`128`	`128`	`assert {"foo":"foo","bar":"bar"}==obj._attrs`
`129`	`129`	`assert {}==obj._updated_attrs`
`130`	`130`
	`131`	`+deftest_update_attrs_deleted(self,fake_manager):`
	`132`	`+obj=FakeObject(fake_manager, {"foo":"foo","bar":"bar"})`
	`133`	`+obj.bar="baz"`
	`134`	`+obj._update_attrs({"foo":"foo"})`
	`135`	`+assert {"foo":"foo"}==obj._attrs`
	`136`	`+assert {}==obj._updated_attrs`
	`137`	`+`
`131`	`138`	`deftest_create_managers(self,fake_gitlab,fake_manager):`
`132`	`139`	`classObjectWithManager(FakeObject):`
`133`	`140`	`_managers= (("fakes","FakeManager"),)`

Comments

(0)