Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitaa972d4

Browse files
chore: update type-hints return signature for GetWithoutIdMixin methods
Commitf0152dc removed situationwhere `get()` in a `GetWithoutIdMixin` based class could return `None`Update the type-hints to no longer return `Optional` AKA `None`
1 parentb2e6f3b commitaa972d4

12 files changed

+50
-66
lines changed

‎gitlab/mixins.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ class GetWithoutIdMixin(_RestManagerBase):
126126
@exc.on_http_error(exc.GitlabGetError)
127127
defget(
128128
self,id:Optional[Union[int,str]]=None,**kwargs:Any
129-
)->Optional[base.RESTObject]:
129+
)->base.RESTObject:
130130
"""Retrieve a single object.
131131
132132
Args:

‎gitlab/v4/objects/appearance.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,5 +60,5 @@ def update(
6060

6161
defget(
6262
self,id:Optional[Union[int,str]]=None,**kwargs:Any
63-
)->Optional[ApplicationAppearance]:
64-
returncast(Optional[ApplicationAppearance],super().get(id=id,**kwargs))
63+
)->ApplicationAppearance:
64+
returncast(ApplicationAppearance,super().get(id=id,**kwargs))

‎gitlab/v4/objects/export_import.py

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,8 @@ class GroupExportManager(GetWithoutIdMixin, CreateMixin, RESTManager):
2424
_obj_cls=GroupExport
2525
_from_parent_attrs= {"group_id":"id"}
2626

27-
defget(
28-
self,id:Optional[Union[int,str]]=None,**kwargs:Any
29-
)->Optional[GroupExport]:
30-
returncast(Optional[GroupExport],super().get(id=id,**kwargs))
27+
defget(self,id:Optional[Union[int,str]]=None,**kwargs:Any)->GroupExport:
28+
returncast(GroupExport,super().get(id=id,**kwargs))
3129

3230

3331
classGroupImport(RESTObject):
@@ -39,10 +37,8 @@ class GroupImportManager(GetWithoutIdMixin, RESTManager):
3937
_obj_cls=GroupImport
4038
_from_parent_attrs= {"group_id":"id"}
4139

42-
defget(
43-
self,id:Optional[Union[int,str]]=None,**kwargs:Any
44-
)->Optional[GroupImport]:
45-
returncast(Optional[GroupImport],super().get(id=id,**kwargs))
40+
defget(self,id:Optional[Union[int,str]]=None,**kwargs:Any)->GroupImport:
41+
returncast(GroupImport,super().get(id=id,**kwargs))
4642

4743

4844
classProjectExport(DownloadMixin,RefreshMixin,RESTObject):
@@ -55,10 +51,8 @@ class ProjectExportManager(GetWithoutIdMixin, CreateMixin, RESTManager):
5551
_from_parent_attrs= {"project_id":"id"}
5652
_create_attrs=RequiredOptional(optional=("description",))
5753

58-
defget(
59-
self,id:Optional[Union[int,str]]=None,**kwargs:Any
60-
)->Optional[ProjectExport]:
61-
returncast(Optional[ProjectExport],super().get(id=id,**kwargs))
54+
defget(self,id:Optional[Union[int,str]]=None,**kwargs:Any)->ProjectExport:
55+
returncast(ProjectExport,super().get(id=id,**kwargs))
6256

6357

6458
classProjectImport(RefreshMixin,RESTObject):
@@ -70,7 +64,5 @@ class ProjectImportManager(GetWithoutIdMixin, RESTManager):
7064
_obj_cls=ProjectImport
7165
_from_parent_attrs= {"project_id":"id"}
7266

73-
defget(
74-
self,id:Optional[Union[int,str]]=None,**kwargs:Any
75-
)->Optional[ProjectImport]:
76-
returncast(Optional[ProjectImport],super().get(id=id,**kwargs))
67+
defget(self,id:Optional[Union[int,str]]=None,**kwargs:Any)->ProjectImport:
68+
returncast(ProjectImport,super().get(id=id,**kwargs))

‎gitlab/v4/objects/merge_request_approvals.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ class ProjectApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTManager):
4747

4848
defget(
4949
self,id:Optional[Union[int,str]]=None,**kwargs:Any
50-
)->Optional[ProjectApproval]:
51-
returncast(Optional[ProjectApproval],super().get(id=id,**kwargs))
50+
)->ProjectApproval:
51+
returncast(ProjectApproval,super().get(id=id,**kwargs))
5252

5353
@exc.on_http_error(exc.GitlabUpdateError)
5454
defset_approvers(
@@ -112,8 +112,8 @@ class ProjectMergeRequestApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTMan
112112

113113
defget(
114114
self,id:Optional[Union[int,str]]=None,**kwargs:Any
115-
)->Optional[ProjectMergeRequestApproval]:
116-
returncast(Optional[ProjectMergeRequestApproval],super().get(id=id,**kwargs))
115+
)->ProjectMergeRequestApproval:
116+
returncast(ProjectMergeRequestApproval,super().get(id=id,**kwargs))
117117

118118
@exc.on_http_error(exc.GitlabUpdateError)
119119
defset_approvers(
@@ -254,7 +254,5 @@ class ProjectMergeRequestApprovalStateManager(GetWithoutIdMixin, RESTManager):
254254

255255
defget(
256256
self,id:Optional[Union[int,str]]=None,**kwargs:Any
257-
)->Optional[ProjectMergeRequestApprovalState]:
258-
returncast(
259-
Optional[ProjectMergeRequestApprovalState],super().get(id=id,**kwargs)
260-
)
257+
)->ProjectMergeRequestApprovalState:
258+
returncast(ProjectMergeRequestApprovalState,super().get(id=id,**kwargs))

‎gitlab/v4/objects/notification_settings.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ class NotificationSettingsManager(GetWithoutIdMixin, UpdateMixin, RESTManager):
4040

4141
defget(
4242
self,id:Optional[Union[int,str]]=None,**kwargs:Any
43-
)->Optional[NotificationSettings]:
44-
returncast(Optional[NotificationSettings],super().get(id=id,**kwargs))
43+
)->NotificationSettings:
44+
returncast(NotificationSettings,super().get(id=id,**kwargs))
4545

4646

4747
classGroupNotificationSettings(NotificationSettings):
@@ -55,8 +55,8 @@ class GroupNotificationSettingsManager(NotificationSettingsManager):
5555

5656
defget(
5757
self,id:Optional[Union[int,str]]=None,**kwargs:Any
58-
)->Optional[GroupNotificationSettings]:
59-
returncast(Optional[GroupNotificationSettings],super().get(id=id,**kwargs))
58+
)->GroupNotificationSettings:
59+
returncast(GroupNotificationSettings,super().get(id=id,**kwargs))
6060

6161

6262
classProjectNotificationSettings(NotificationSettings):
@@ -70,5 +70,5 @@ class ProjectNotificationSettingsManager(NotificationSettingsManager):
7070

7171
defget(
7272
self,id:Optional[Union[int,str]]=None,**kwargs:Any
73-
)->Optional[ProjectNotificationSettings]:
74-
returncast(Optional[ProjectNotificationSettings],super().get(id=id,**kwargs))
73+
)->ProjectNotificationSettings:
74+
returncast(ProjectNotificationSettings,super().get(id=id,**kwargs))

‎gitlab/v4/objects/pipelines.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -252,8 +252,8 @@ class ProjectPipelineTestReportManager(GetWithoutIdMixin, RESTManager):
252252

253253
defget(
254254
self,id:Optional[Union[int,str]]=None,**kwargs:Any
255-
)->Optional[ProjectPipelineTestReport]:
256-
returncast(Optional[ProjectPipelineTestReport],super().get(id=id,**kwargs))
255+
)->ProjectPipelineTestReport:
256+
returncast(ProjectPipelineTestReport,super().get(id=id,**kwargs))
257257

258258

259259
classProjectPipelineTestReportSummary(RESTObject):
@@ -267,7 +267,5 @@ class ProjectPipelineTestReportSummaryManager(GetWithoutIdMixin, RESTManager):
267267

268268
defget(
269269
self,id:Optional[Union[int,str]]=None,**kwargs:Any
270-
)->Optional[ProjectPipelineTestReportSummary]:
271-
returncast(
272-
Optional[ProjectPipelineTestReportSummary],super().get(id=id,**kwargs)
273-
)
270+
)->ProjectPipelineTestReportSummary:
271+
returncast(ProjectPipelineTestReportSummary,super().get(id=id,**kwargs))

‎gitlab/v4/objects/projects.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1030,5 +1030,5 @@ class ProjectStorageManager(GetWithoutIdMixin, RESTManager):
10301030

10311031
defget(
10321032
self,id:Optional[Union[int,str]]=None,**kwargs:Any
1033-
)->Optional[ProjectStorage]:
1034-
returncast(Optional[ProjectStorage],super().get(id=id,**kwargs))
1033+
)->ProjectStorage:
1034+
returncast(ProjectStorage,super().get(id=id,**kwargs))

‎gitlab/v4/objects/push_rules.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,5 +53,5 @@ class ProjectPushRulesManager(
5353

5454
defget(
5555
self,id:Optional[Union[int,str]]=None,**kwargs:Any
56-
)->Optional[ProjectPushRules]:
57-
returncast(Optional[ProjectPushRules],super().get(id=id,**kwargs))
56+
)->ProjectPushRules:
57+
returncast(ProjectPushRules,super().get(id=id,**kwargs))

‎gitlab/v4/objects/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,5 +117,5 @@ def update(
117117

118118
defget(
119119
self,id:Optional[Union[int,str]]=None,**kwargs:Any
120-
)->Optional[ApplicationSettings]:
121-
returncast(Optional[ApplicationSettings],super().get(id=id,**kwargs))
120+
)->ApplicationSettings:
121+
returncast(ApplicationSettings,super().get(id=id,**kwargs))

‎gitlab/v4/objects/statistics.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ class ProjectAdditionalStatisticsManager(GetWithoutIdMixin, RESTManager):
2626

2727
defget(
2828
self,id:Optional[Union[int,str]]=None,**kwargs:Any
29-
)->Optional[ProjectAdditionalStatistics]:
30-
returncast(Optional[ProjectAdditionalStatistics],super().get(id=id,**kwargs))
29+
)->ProjectAdditionalStatistics:
30+
returncast(ProjectAdditionalStatistics,super().get(id=id,**kwargs))
3131

3232

3333
classIssuesStatistics(RefreshMixin,RESTObject):
@@ -40,8 +40,8 @@ class IssuesStatisticsManager(GetWithoutIdMixin, RESTManager):
4040

4141
defget(
4242
self,id:Optional[Union[int,str]]=None,**kwargs:Any
43-
)->Optional[IssuesStatistics]:
44-
returncast(Optional[IssuesStatistics],super().get(id=id,**kwargs))
43+
)->IssuesStatistics:
44+
returncast(IssuesStatistics,super().get(id=id,**kwargs))
4545

4646

4747
classGroupIssuesStatistics(RefreshMixin,RESTObject):
@@ -55,8 +55,8 @@ class GroupIssuesStatisticsManager(GetWithoutIdMixin, RESTManager):
5555

5656
defget(
5757
self,id:Optional[Union[int,str]]=None,**kwargs:Any
58-
)->Optional[GroupIssuesStatistics]:
59-
returncast(Optional[GroupIssuesStatistics],super().get(id=id,**kwargs))
58+
)->GroupIssuesStatistics:
59+
returncast(GroupIssuesStatistics,super().get(id=id,**kwargs))
6060

6161

6262
classProjectIssuesStatistics(RefreshMixin,RESTObject):
@@ -70,5 +70,5 @@ class ProjectIssuesStatisticsManager(GetWithoutIdMixin, RESTManager):
7070

7171
defget(
7272
self,id:Optional[Union[int,str]]=None,**kwargs:Any
73-
)->Optional[ProjectIssuesStatistics]:
74-
returncast(Optional[ProjectIssuesStatistics],super().get(id=id,**kwargs))
73+
)->ProjectIssuesStatistics:
74+
returncast(ProjectIssuesStatistics,super().get(id=id,**kwargs))

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp