Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commita4ea0fe

Browse files
authored
Merge pull request#702 from jpiron/eq_hash
Implement __eq__ and __hash__ methods
2 parents57fa4e3 +3d60850 commita4ea0fe

File tree

2 files changed

+34
-1
lines changed

2 files changed

+34
-1
lines changed

‎gitlab/base.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,16 @@ def __repr__(self):
9696
else:
9797
return'<%s>'%self.__class__.__name__
9898

99+
def__eq__(self,other):
100+
ifself.get_id()andother.get_id():
101+
returnself.get_id()==other.get_id()
102+
returnsuper().__eq__(other)
103+
104+
def__hash__(self):
105+
ifnotself.get_id():
106+
returnsuper().__hash__()
107+
returnhash(self.get_id())
108+
99109
def_create_managers(self):
100110
managers=getattr(self,'_managers',None)
101111
ifmanagersisNone:
@@ -112,7 +122,7 @@ def _update_attrs(self, new_attrs):
112122

113123
defget_id(self):
114124
"""Returns the id of the resource."""
115-
ifself._id_attrisNone:
125+
ifself._id_attrisNoneornothasattr(self,self._id_attr):
116126
returnNone
117127
returngetattr(self,self._id_attr)
118128

‎gitlab/tests/test_base.py

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,3 +134,26 @@ class ObjectWithManager(FakeObject):
134134
self.assertIsInstance(obj.fakes,FakeManager)
135135
self.assertEqual(obj.fakes.gitlab,self.gitlab)
136136
self.assertEqual(obj.fakes._parent,obj)
137+
138+
deftest_equality(self):
139+
obj1=FakeObject(self.manager, {'id':'foo'})
140+
obj2=FakeObject(self.manager, {'id':'foo','other_attr':'bar'})
141+
self.assertEqual(obj1,obj2)
142+
143+
deftest_equality_custom_id(self):
144+
classOtherFakeObject(FakeObject):
145+
_id_attr='foo'
146+
147+
obj1=OtherFakeObject(self.manager, {'foo':'bar'})
148+
obj2=OtherFakeObject(self.manager, {'foo':'bar','other_attr':'baz'})
149+
self.assertEqual(obj1,obj2)
150+
151+
deftest_inequality(self):
152+
obj1=FakeObject(self.manager, {'id':'foo'})
153+
obj2=FakeObject(self.manager, {'id':'bar'})
154+
self.assertNotEqual(obj1,obj2)
155+
156+
deftest_inequality_no_id(self):
157+
obj1=FakeObject(self.manager, {'attr1':'foo'})
158+
obj2=FakeObject(self.manager, {'attr1':'bar'})
159+
self.assertNotEqual(obj1,obj2)

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp