NotificationsYou must be signed in to change notification settings
Fork674
Star2.4k

Commita0cc815

committed

chore: enable mypy checkstrict_equality

Enable the `mypy` `strict_equality` check.

1 parente409811 commita0cc815Copy full SHA for a0cc815

File tree

3 files changed

+30

-14

lines changed

gitlab/v4/objects
- users.py
pyproject.toml
tests/functional/api
- test_users.py

3 files changed

+30

-14

lines changed

`‎gitlab/v4/objects/users.py‎`

Lines changed: 16 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ class User(SaveMixin, ObjectDeleteMixin, RESTObject):`
`163`	`163`
`164`	`164`	`@cli.register_custom_action("User")`
`165`	`165`	`@exc.on_http_error(exc.GitlabBlockError)`
`166`		`-defblock(self,**kwargs:Any)->Union[Dict[str,Any],requests.Response]:`
	`166`	`+defblock(self,**kwargs:Any)->bool:`
`167`	`167`	`"""Block the user.`
`168`	`168`
`169`	`169`	`Args:`
`@@ -177,10 +177,13 @@ def block(self, **kwargs: Any) -> Union[Dict[str, Any], requests.Response]:`
`177`	`177`	`Whether the user status has been changed`
`178`	`178`	`"""`
`179`	`179`	`path=f"/users/{self.encoded_id}/block"`
`180`		`-server_data=self.manager.gitlab.http_post(path,**kwargs)`
`181`		`-ifserver_dataisTrue:`
`182`		`-self._attrs["state"]="blocked"`
`183`		`-returnserver_data`
	`180`	`+# NOTE: Undocumented behavior of the GitLab API is that it returns a boolean`
	`181`	`+server_data=cast(bool,self.manager.gitlab.http_post(path,**kwargs))`
	`182`	`+ifisinstance(server_data,bool):`
	`183`	`+ifserver_dataisTrue:`
	`184`	`+self._attrs["state"]="blocked"`
	`185`	`+returnserver_data`
	`186`	`+returnFalse`
`184`	`187`
`185`	`188`	`@cli.register_custom_action("User")`
`186`	`189`	`@exc.on_http_error(exc.GitlabFollowError)`
`@@ -220,7 +223,7 @@ def unfollow(self, **kwargs: Any) -> Union[Dict[str, Any], requests.Response]:`
`220`	`223`
`221`	`224`	`@cli.register_custom_action("User")`
`222`	`225`	`@exc.on_http_error(exc.GitlabUnblockError)`
`223`		`-defunblock(self,**kwargs:Any)->Union[Dict[str,Any],requests.Response]:`
	`226`	`+defunblock(self,**kwargs:Any)->bool:`
`224`	`227`	`"""Unblock the user.`
`225`	`228`
`226`	`229`	`Args:`
`@@ -234,10 +237,13 @@ def unblock(self, **kwargs: Any) -> Union[Dict[str, Any], requests.Response]:`
`234`	`237`	`Whether the user status has been changed`
`235`	`238`	`"""`
`236`	`239`	`path=f"/users/{self.encoded_id}/unblock"`
`237`		`-server_data=self.manager.gitlab.http_post(path,**kwargs)`
`238`		`-ifserver_dataisTrue:`
`239`		`-self._attrs["state"]="active"`
`240`		`-returnserver_data`
	`240`	`+# NOTE: Undocumented behavior of the GitLab API is that it returns a boolean`
	`241`	`+server_data=cast(bool,self.manager.gitlab.http_post(path,**kwargs))`
	`242`	`+ifisinstance(server_data,bool):`
	`243`	`+ifserver_dataisTrue:`
	`244`	`+self._attrs["state"]="active"`
	`245`	`+returnserver_data`
	`246`	`+returnFalse`
`241`	`247`
`242`	`248`	`@cli.register_custom_action("User")`
`243`	`249`	`@exc.on_http_error(exc.GitlabDeactivateError)`

`‎pyproject.toml‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@ disallow_incomplete_defs = true`
`13`	`13`	`disallow_subclassing_any =true`
`14`	`14`	`disallow_untyped_decorators =true`
`15`	`15`	`disallow_untyped_defs =true`
	`16`	`+no_implicit_reexport =true`
	`17`	`+strict_equality =true`
`16`	`18`	`warn_redundant_casts =true`
`17`	`19`	`warn_unused_configs =true`
`18`	`20`	`warn_unused_ignores =true`
`@@ -21,8 +23,6 @@ warn_unused_ignores = true`
`21`	`23`	`# disallow_any_generics = true`
`22`	`24`	`# disallow_untyped_calls = true`
`23`	`25`	`# no_implicit_optional = true`
`24`		`-no_implicit_reexport =true`
`25`		`-# strict_equality = true`
`26`	`26`	`# warn_return_any = true`
`27`	`27`
`28`	`28`	`[[tool.mypy.overrides]]# Overrides for currently untyped modules`

`‎tests/functional/api/test_users.py‎`

Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,14 +28,24 @@ def test_create_user(gl, fixture_dir):`
`28`	`28`
`29`	`29`
`30`	`30`	`deftest_block_user(gl,user):`
`31`		`-user.block()`
	`31`	`+result=user.block()`
	`32`	`+assertresultisTrue`
`32`	`33`	`users=gl.users.list(blocked=True)`
`33`	`34`	`assertuserinusers`
`34`	`35`
`35`		`-user.unblock()`
	`36`	`+# block again`
	`37`	`+result=user.block()`
	`38`	`+assertresultisTrue`
	`39`	`+`
	`40`	`+result=user.unblock()`
	`41`	`+assertresultisTrue`
`36`	`42`	`users=gl.users.list(blocked=False)`
`37`	`43`	`assertuserinusers`
`38`	`44`
	`45`	`+# unblock again`
	`46`	`+result=user.unblock()`
	`47`	`+assertresultisTrue`
	`48`	`+`
`39`	`49`
`40`	`50`	`deftest_ban_user(gl,user):`
`41`	`51`	`user.ban()`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita0cc815

File tree

3 files changed

3 files changed

`‎gitlab/v4/objects/users.py‎`

`‎pyproject.toml‎`

`‎tests/functional/api/test_users.py‎`

0 commit comments