NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

Commit9a451a8

committed

chore: fix issue with adding type-hints to 'manager' attribute

When attempting to add type-hints to the the 'manager' attribute intoa RESTObject derived class it would break things.This was because our auto-manager creation code would automaticallyadd the specified annotated manager to the 'manager' attribute. Thisbreaks things.Now check in our auto-manager creation if our attribute is called'manager'. If so we ignore it.

1 parent2cd15ac commit9a451a8Copy full SHA for 9a451a8

File tree

1 file changed

-0

lines changed

gitlab
- base.py

1 file changed

-0

lines changed

`‎gitlab/base.py`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -150,6 +150,10 @@ def _create_managers(self) -> None:`
`150`	`150`	`# annotations. If an attribute is annotated as being a *Manager type`
`151`	`151`	`# then we create the manager and assign it to the attribute.`
`152`	`152`	`forattr,annotationinsorted(self.__annotations__.items()):`
	`153`	`+# We ignore creating a manager for the 'manager' attribute as that`
	`154`	`+# is done in the self.__init__() method`
	`155`	`+ifattrin ("manager",):`
	`156`	`+continue`
`153`	`157`	`ifnotisinstance(annotation, (type,str)):`
`154`	`158`	`continue`
`155`	`159`	`ifisinstance(annotation,type):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9a451a8

File tree

1 file changed

1 file changed

`‎gitlab/base.py`

0 commit comments