Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit97cae38

Browse files
Shreya-7nejch
authored andcommitted
fix: use epic id instead of iid for epic notes
1 parent8dbaa5c commit97cae38

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

‎gitlab/v4/objects/notes.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ class GroupEpicNote(SaveMixin, ObjectDeleteMixin, RESTObject):
4949

5050

5151
classGroupEpicNoteManager(CRUDMixin,RESTManager):
52-
_path="/groups/{group_id}/epics/{epic_iid}/notes"
52+
_path="/groups/{group_id}/epics/{epic_id}/notes"
5353
_obj_cls=GroupEpicNote
54-
_from_parent_attrs= {"group_id":"group_id","epic_iid":"iid"}
54+
_from_parent_attrs= {"group_id":"group_id","epic_id":"id"}
5555
_create_attrs=RequiredOptional(required=("body",),optional=("created_at",))
5656
_update_attrs=RequiredOptional(required=("body",))
5757

@@ -68,11 +68,11 @@ class GroupEpicDiscussionNote(SaveMixin, ObjectDeleteMixin, RESTObject):
6868
classGroupEpicDiscussionNoteManager(
6969
GetMixin,CreateMixin,UpdateMixin,DeleteMixin,RESTManager
7070
):
71-
_path="/groups/{group_id}/epics/{epic_iid}/discussions/{discussion_id}/notes"
71+
_path="/groups/{group_id}/epics/{epic_id}/discussions/{discussion_id}/notes"
7272
_obj_cls=GroupEpicDiscussionNote
7373
_from_parent_attrs= {
7474
"group_id":"group_id",
75-
"epic_iid":"epic_iid",
75+
"epic_id":"epic_id",
7676
"discussion_id":"id",
7777
}
7878
_create_attrs=RequiredOptional(required=("body",),optional=("created_at",))

‎tests/functional/ee-test.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
I_P1=1
99
I_P2=1
1010
EPIC_ISSUES= [4,5]
11+
EPIC_NOTES= ["rubeus","hagrid"]
1112
G1="group1"
1213
LDAP_CN="app1"
1314
LDAP_PROVIDER="ldapmain"
@@ -154,5 +155,11 @@ def end_log():
154155
foreiinepic.issues.list():
155156
ei.delete()
156157

158+
# epic notes
159+
assertnotepic.notes.list()
160+
foriinEPIC_NOTES:
161+
epic.notes.create({"body":i})
162+
assertlen(EPIC_NOTES==len(epic.notes.list()))
163+
157164
epic.delete()
158165
end_log()

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp