Commit919d0ae

committed

chore: add testing of Python 3.14

Also fix __annotations__ not working in Python 3.14 by using theannotation on the 'class' instead of on the 'instance'Closes:#3013

1 parent3739b5d commit919d0aeCopy full SHA for 919d0ae

File tree

-6

lines changed

-6

lines changed

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,10 +36,8 @@ jobs:`
`36`	`36`	`toxenv:py312,smoke`
`37`	`37`	`-version:"3.13"`
`38`	`38`	`toxenv:py313,smoke`
`39`		`-# NOTE(jlvillal): 2024-10-17: Enable this once we fix`
`40`		`-# https://github.com/python-gitlab/python-gitlab/issues/3013`
`41`		`-# - version: "3.14.0-alpha - 3.14" # SemVer's version range syntax`
`42`		`-# toxenv: py314,smoke`
	`39`	`+ -version:"3.14.0-alpha - 3.14"# SemVer's version range syntax`
	`40`	`+toxenv:py314,smoke`
`43`	`41`	`include:`
`44`	`42`	`-os:macos-latest`
`45`	`43`	`python:`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -201,12 +201,12 @@ def _create_managers(self) -> None:`
`201`	`201`	`# NOTE(jlvillal): We are creating our managers by looking at the class`
`202`	`202`	`# annotations. If an attribute is annotated as being a *Manager type`
`203`	`203`	`# then we create the manager and assign it to the attribute.`
`204`		`-forattr,annotationinsorted(self.__annotations__.items()):`
	`204`	`+forattr,annotationinsorted(self.__class__.__annotations__.items()):`
`205`	`205`	`# We ignore creating a manager for the 'manager' attribute as that`
`206`	`206`	`# is done in the self.__init__() method`
`207`	`207`	`ifattrin ("manager",):`
`208`	`208`	`continue`
`209`		`-ifnotisinstance(annotation, (type,str)):`
	`209`	`+ifnotisinstance(annotation, (type,str)):# pragma: no cover`
`210`	`210`	`continue`
`211`	`211`	`ifisinstance(annotation,type):`
`212`	`212`	`cls_name=annotation.__name__`

Comments

(0)