NotificationsYou must be signed in to change notification settings
Fork674
Star2.4k

Commit75758bf

committed

chore(objects): useself.encoded_id where applicable

Updated a few remaining usages of `self.id` to use `self.encoded_id`as for the most part we shouldn't be using `self.id`There are now only a few (4 lines of code) remaining uses of`self.id`, most of which seem that they should stay that way.

1 parent34110dd commit75758bfCopy full SHA for 75758bf

File tree

2 files changed

-7

lines changed

gitlab/v4/objects
- todos.py
- users.py

2 files changed

-7

lines changed

`‎gitlab/v4/objects/todos.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ def mark_as_done(self, **kwargs: Any) -> Dict[str, Any]:`
`27`	`27`	`Returns:`
`28`	`28`	`A dict with the result`
`29`	`29`	`"""`
`30`		`-path=f"{self.manager.path}/{self.id}/mark_as_done"`
	`30`	`+path=f"{self.manager.path}/{self.encoded_id}/mark_as_done"`
`31`	`31`	`server_data=self.manager.gitlab.http_post(path,**kwargs)`
`32`	`32`	`ifTYPE_CHECKING:`
`33`	`33`	`assertisinstance(server_data,dict)`

`‎gitlab/v4/objects/users.py‎`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ def block(self, **kwargs: Any) -> Union[Dict[str, Any], requests.Response]:`
`179`	`179`	`Returns:`
`180`	`180`	`Whether the user status has been changed`
`181`	`181`	`"""`
`182`		`-path=f"/users/{self.id}/block"`
	`182`	`+path=f"/users/{self.encoded_id}/block"`
`183`	`183`	`server_data=self.manager.gitlab.http_post(path,**kwargs)`
`184`	`184`	`ifserver_dataisTrue:`
`185`	`185`	`self._attrs["state"]="blocked"`
`@@ -200,7 +200,7 @@ def follow(self, **kwargs: Any) -> Union[Dict[str, Any], requests.Response]:`
`200`	`200`	`Returns:`
`201`	`201`	`The new object data (not a RESTObject)`
`202`	`202`	`"""`
`203`		`-path=f"/users/{self.id}/follow"`
	`203`	`+path=f"/users/{self.encoded_id}/follow"`
`204`	`204`	`returnself.manager.gitlab.http_post(path,**kwargs)`
`205`	`205`
`206`	`206`	`@cli.register_custom_action("User")`
`@@ -218,7 +218,7 @@ def unfollow(self, **kwargs: Any) -> Union[Dict[str, Any], requests.Response]:`
`218`	`218`	`Returns:`
`219`	`219`	`The new object data (not a RESTObject)`
`220`	`220`	`"""`
`221`		`-path=f"/users/{self.id}/unfollow"`
	`221`	`+path=f"/users/{self.encoded_id}/unfollow"`
`222`	`222`	`returnself.manager.gitlab.http_post(path,**kwargs)`
`223`	`223`
`224`	`224`	`@cli.register_custom_action("User")`
`@@ -236,7 +236,7 @@ def unblock(self, **kwargs: Any) -> Union[Dict[str, Any], requests.Response]:`
`236`	`236`	`Returns:`
`237`	`237`	`Whether the user status has been changed`
`238`	`238`	`"""`
`239`		`-path=f"/users/{self.id}/unblock"`
	`239`	`+path=f"/users/{self.encoded_id}/unblock"`
`240`	`240`	`server_data=self.manager.gitlab.http_post(path,**kwargs)`
`241`	`241`	`ifserver_dataisTrue:`
`242`	`242`	`self._attrs["state"]="active"`
`@@ -257,7 +257,7 @@ def deactivate(self, **kwargs: Any) -> Union[Dict[str, Any], requests.Response]:`
`257`	`257`	`Returns:`
`258`	`258`	`Whether the user status has been changed`
`259`	`259`	`"""`
`260`		`-path=f"/users/{self.id}/deactivate"`
	`260`	`+path=f"/users/{self.encoded_id}/deactivate"`
`261`	`261`	`server_data=self.manager.gitlab.http_post(path,**kwargs)`
`262`	`262`	`ifserver_data:`
`263`	`263`	`self._attrs["state"]="deactivated"`
`@@ -278,7 +278,7 @@ def activate(self, **kwargs: Any) -> Union[Dict[str, Any], requests.Response]:`
`278`	`278`	`Returns:`
`279`	`279`	`Whether the user status has been changed`
`280`	`280`	`"""`
`281`		`-path=f"/users/{self.id}/activate"`
	`281`	`+path=f"/users/{self.encoded_id}/activate"`
`282`	`282`	`server_data=self.manager.gitlab.http_post(path,**kwargs)`
`283`	`283`	`ifserver_data:`
`284`	`284`	`self._attrs["state"]="active"`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit75758bf

File tree

2 files changed

2 files changed

`‎gitlab/v4/objects/todos.py‎`

`‎gitlab/v4/objects/users.py‎`

0 commit comments