Commit6d941bd

authored

Merge pull request#1045 from python-gitlab/revert-1003-feat/all-keyset-pagination

Revert "feat: use keyset pagination by default for `all=True`"

2 parents6c5458a +6f843b6 commit6d941bdCopy full SHA for 6d941bd

File tree

-11

lines changed

-11

lines changed

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -204,11 +204,6 @@ listing methods support the ``page`` and ``per_page`` parameters:
`204`	`204`	By default GitLab does not return the complete list of items. Use the ``all``
`205`	`205`	`parameter to get all the items when using listing methods:`
`206`	`206`
`207`		`-..warning::`
`208`		`-`
`209`		`- The all=True option uses keyset pagination by default if order_by is not supplied,`
`210`		`- or if order_by="id".`
`211`		`-`
`212`	`207`	`..code-block::python`
`213`	`208`
`214`	`209`	`all_groups= gl.groups.list(all=True)`
`@@ -408,3 +403,4 @@ parameter to that API invocation:`
`408`	`403`
`409`	`404`	`gl= gitlab.gitlab(url, token,api_version=4)`
`410`	`405`	`gl.projects.import_github(ACCESS_TOKEN,123456,"root",timeout=120.0)`
	`406`	`+`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -641,12 +641,6 @@ def http_list(self, path, query_data=None, as_list=None, **kwargs):`
`641`	`641`	`get_all=kwargs.pop("all",False)`
`642`	`642`	`url=self._build_url(path)`
`643`	`643`
`644`		`-# use keyset pagination automatically, if all=True`
`645`		`-order_by=kwargs.get("order_by")`
`646`		`-ifget_alland (notorder_byororder_by=="id"):`
`647`		`-kwargs["pagination"]="keyset"`
`648`		`-kwargs["order_by"]="id"`
`649`		`-`
`650`	`644`	`ifget_allisTrueandas_listisTrue:`
`651`	`645`	`returnlist(GitlabList(self,url,query_data,**kwargs))`
`652`	`646`

Comments

(0)