Commit67f9537

Philipp Busch

committed

Convert response list to single data source for iid requests

1 parent5f444e4 commit67f9537Copy full SHA for 67f9537

File tree

+16

-0

lines changed

+16

-0

lines changed

Lines changed: 16 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -377,6 +377,22 @@ def __init__(self, gl, data=None, **kwargs):`
`377`	`377`	`data=self.gitlab.get(self.__class__,data,**kwargs)`
`378`	`378`	`self._from_api=True`
`379`	`379`
	`380`	`+# the API returned a list because custom kwargs where used`
	`381`	`+# instead of the id to request an object. Usually parameters`
	`382`	`+# other than an id return ambiguous results. However in the`
	`383`	`+# gitlab universe iids together with a project_id are`
	`384`	`+# unambiguous for merge requests and issues, too.`
	`385`	`+# So if there is only one element we can use it as our data`
	`386`	`+# source.`
	`387`	`+if'iid'inkwargsandisinstance(data,list):`
	`388`	`+iflen(data)<1:`
	`389`	`+raiseGitlabGetError('Not found')`
	`390`	`+eliflen(data)==1:`
	`391`	`+data=data[0]`
	`392`	`+else:`
	`393`	`+raiseGitlabGetError('Impossible! You found multiple'`
	`394`	`+' elements with the same iid.')`
	`395`	`+`
`380`	`396`	`self._set_from_dict(data)`
`381`	`397`
`382`	`398`	`ifkwargs:`

Comments

(0)