Commit65ecadc

Charles

committed

fix(objects): update set_approvers function call

Added a miss paramter update to the set_approvers function

1 parent2cf12c7 commit65ecadcCopy full SHA for 65ecadc

File tree

+12

-6

lines changed

+12

-6

lines changed

Lines changed: 12 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -2685,7 +2685,9 @@ class ProjectMergeRequestApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTMan`
`2685`	`2685`	`_update_uses_post=True`
`2686`	`2686`
`2687`	`2687`	`@exc.on_http_error(exc.GitlabUpdateError)`
`2688`		`-defset_approvers(self,approvals_required,approver_ids=None,approver_group_ids=None,**kwargs):`
	`2688`	`+defset_approvers(`
	`2689`	`+self,approvals_required,approver_ids=None,approver_group_ids=None,**kwargs`
	`2690`	`+ ):`
`2689`	`2691`	`"""Change MR-level allowed approvers and approver groups.`
`2690`	`2692`
`2691`	`2693`	`Args:`
`@@ -2700,12 +2702,16 @@ def set_approvers(self, approvals_required, approver_ids=None, approver_group_id`
`2700`	`2702`	`approver_ids=approver_idsor []`
`2701`	`2703`	`approver_group_ids=approver_group_idsor []`
`2702`	`2704`
`2703`		`-path="%s/%s/approval_rules"% (self._parent.manager.path,self._parent.get_id())`
	`2705`	`+path="%s/%s/approval_rules"% (`
	`2706`	`+self._parent.manager.path,`
	`2707`	`+self._parent.get_id(),`
	`2708`	`+ )`
`2704`	`2709`	`data= {`
`2705`		`-"approvals_required":approvals_required,`
`2706`		`-"rule_type":"regular",`
`2707`		`-"user_ids":approver_ids,`
`2708`		`-"group_ids":approver_group_ids}`
	`2710`	`+"approvals_required":approvals_required,`
	`2711`	`+"rule_type":"regular",`
	`2712`	`+"user_ids":approver_ids,`
	`2713`	`+"group_ids":approver_group_ids,`
	`2714`	`+ }`
`2709`	`2715`	`self.gitlab.http_put(path,post_data=data,**kwargs)`
`2710`	`2716`
`2711`	`2717`

Comments

(0)