Commit65abb85

emanueleaina

authored and

nejch

committed

fix(cli): Enable debug before doing auth

Authentication issues are currently hard to debug since `--debug` onlyhas effect after `gl.auth()` has been called.For example, a 401 error is printed without any details about the actualHTTP request being sent: $ gitlab --debug --server-urlhttps://gitlab.com current-user get 401: 401 UnauthorizedBy moving the call to `gl.enable_debug()` the usual debug logs getprinted before the final error message.Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

1 parentd8a657b commit65abb85Copy full SHA for 65abb85

File tree

1 file changed

-3

lines changed

gitlab
- cli.py

1 file changed

-3

lines changed

`‎gitlab/cli.py`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -366,14 +366,13 @@ def main() -> None:`
`366`	`366`
`367`	`367`	`try:`
`368`	`368`	`gl=gitlab.Gitlab.merge_config(vars(options),gitlab_id,config_files)`
	`369`	`+ifdebug:`
	`370`	`+gl.enable_debug()`
`369`	`371`	`ifgl.private_tokenorgl.oauth_token:`
`370`	`372`	`gl.auth()`
`371`	`373`	`exceptExceptionase:`
`372`	`374`	`die(str(e))`
`373`	`375`
`374`		`-ifdebug:`
`375`		`-gl.enable_debug()`
`376`		`-`
`377`	`376`	`gitlab.v4.cli.run(`
`378`	`377`	`gl,gitlab_resource,resource_action,args_dict,verbose,output,fields`
`379`	`378`	`)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit65abb85

File tree

1 file changed

1 file changed

`‎gitlab/cli.py`

0 commit comments