NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

Commit630901b

committed

chore: fix E711 error reported by flake8

E711: Comparison to none should be 'if cond is none:'https://www.flake8rules.com/rules/E711.html

1 parent83670a4 commit630901bCopy full SHA for 630901b

File tree

2 files changed

-7

lines changed

gitlab/tests
- test_base.py
- test_config.py

2 files changed

-7

lines changed

`‎gitlab/tests/test_base.py`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ def test_instantiate(self, fake_gitlab, fake_manager):`
`80`	`80`
`81`	`81`	`assert {"foo":"bar"}==obj._attrs`
`82`	`82`	`assert {}==obj._updated_attrs`
`83`		`-assertNone==obj._create_managers()`
	`83`	`+assertobj._create_managers()isNone`
`84`	`84`	`assertfake_manager==obj.manager`
`85`	`85`	`assertfake_gitlab==obj.manager.gitlab`
`86`	`86`
`@@ -112,7 +112,7 @@ def test_get_id(self, fake_manager):`
`112`	`112`	`assert42==obj.get_id()`
`113`	`113`
`114`	`114`	`obj.id=None`
`115`		`-assertNone==obj.get_id()`
	`115`	`+assertobj.get_id()isNone`
`116`	`116`
`117`	`117`	`deftest_custom_id_attr(self,fake_manager):`
`118`	`118`	`classOtherFakeObject(FakeObject):`

`‎gitlab/tests/test_config.py`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ def test_valid_data(m_open, path_exists):`
`154`	`154`	`assert"one"==cp.gitlab_id`
`155`	`155`	`assert"http://one.url"==cp.url`
`156`	`156`	`assert"ABCDEF"==cp.private_token`
`157`		`-assertNone==cp.oauth_token`
	`157`	`+assertcp.oauth_tokenisNone`
`158`	`158`	`assert2==cp.timeout`
`159`	`159`	`assertcp.ssl_verifyisTrue`
`160`	`160`	`assertcp.per_pageisNone`
`@@ -166,7 +166,7 @@ def test_valid_data(m_open, path_exists):`
`166`	`166`	`assert"two"==cp.gitlab_id`
`167`	`167`	`assert"https://two.url"==cp.url`
`168`	`168`	`assert"GHIJKL"==cp.private_token`
`169`		`-assertNone==cp.oauth_token`
	`169`	`+assertcp.oauth_tokenisNone`
`170`	`170`	`assert10==cp.timeout`
`171`	`171`	`assertcp.ssl_verifyisFalse`
`172`	`172`
`@@ -177,7 +177,7 @@ def test_valid_data(m_open, path_exists):`
`177`	`177`	`assert"three"==cp.gitlab_id`
`178`	`178`	`assert"https://three.url"==cp.url`
`179`	`179`	`assert"MNOPQR"==cp.private_token`
`180`		`-assertNone==cp.oauth_token`
	`180`	`+assertcp.oauth_tokenisNone`
`181`	`181`	`assert2==cp.timeout`
`182`	`182`	`assert"/path/to/CA/bundle.crt"==cp.ssl_verify`
`183`	`183`	`assert50==cp.per_page`
`@@ -188,7 +188,7 @@ def test_valid_data(m_open, path_exists):`
`188`	`188`	`cp=config.GitlabConfigParser(gitlab_id="four")`
`189`	`189`	`assert"four"==cp.gitlab_id`
`190`	`190`	`assert"https://four.url"==cp.url`
`191`		`-assertNone==cp.private_token`
	`191`	`+assertcp.private_tokenisNone`
`192`	`192`	`assert"STUV"==cp.oauth_token`
`193`	`193`	`assert2==cp.timeout`
`194`	`194`	`assertcp.ssl_verifyisTrue`
`@@ -227,7 +227,7 @@ def test_data_from_helper(m_open, path_exists, tmp_path):`
`227`	`227`	`cp=config.GitlabConfigParser(gitlab_id="helper")`
`228`	`228`	`assert"helper"==cp.gitlab_id`
`229`	`229`	`assert"https://helper.url"==cp.url`
`230`		`-assertNone==cp.private_token`
	`230`	`+assertcp.private_tokenisNone`
`231`	`231`	`assert"secret"==cp.oauth_token`
`232`	`232`
`233`	`233`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit630901b

File tree

2 files changed

2 files changed

`‎gitlab/tests/test_base.py`

`‎gitlab/tests/test_config.py`

0 commit comments