Commit60c5fd8

authored

Merge pull request#1383 from spyoungtech/dirfix

fix(types): prevent __dir__ in RestObject from producing duplicates

2 parentsdd236a0 +a8e591f commit60c5fd8Copy full SHA for 60c5fd8

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ def __ne__(self, other: object) -> bool:`
`133`	`133`	`returnsuper(RESTObject,self)!=other`
`134`	`134`
`135`	`135`	`def__dir__(self):`
`136`		`-returnsuper(RESTObject,self).__dir__()+list(self.attributes)`
	`136`	`+returnsuper(RESTObject,self).__dir__()\|self.attributes.keys()`
`137`	`137`
`138`	`138`	`def__hash__(self)->int:`
`139`	`139`	`ifnotself.get_id():`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,10 @@ def test_update_attrs_deleted(self, fake_manager):`
`135`	`135`	`assert {"foo":"foo"}==obj._attrs`
`136`	`136`	`assert {}==obj._updated_attrs`
`137`	`137`
	`138`	`+deftest_dir_unique(self,fake_manager):`
	`139`	`+obj=FakeObject(fake_manager, {"manager":"foo"})`
	`140`	`+assertlen(dir(obj))==len(set(dir(obj)))`
	`141`	`+`
`138`	`142`	`deftest_create_managers(self,fake_gitlab,fake_manager):`
`139`	`143`	`classObjectWithManager(FakeObject):`
`140`	`144`	`_managers= (("fakes","FakeManager"),)`

Comments

(0)