Commit5e169be

committed

chore(test): prevent 'job_with_artifact' fixture running forever

Previously the 'job_with_artifact' fixture could run forever. Now giveit up to 60 seconds to complete before failing.

1 parent553f5b0 commit5e169beCopy full SHA for 5e169be

File tree

+11

-0

lines changed

+11

-0

lines changed

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+importlogging`
`1`	`2`	`importsubprocess`
`2`	`3`	`importtextwrap`
`3`	`4`	`importtime`
`@@ -24,12 +25,22 @@`
`24`	`25`
`25`	`26`	`@pytest.fixture(scope="module")`
`26`	`27`	`defjob_with_artifacts(gitlab_runner,project):`
	`28`	`+start_time=time.time()`
	`29`	`+`
`27`	`30`	`project.files.create(data)`
`28`	`31`
`29`	`32`	`jobs=None`
`30`	`33`	`whilenotjobs:`
`31`	`34`	`time.sleep(0.5)`
`32`	`35`	`jobs=project.jobs.list(scope="success")`
	`36`	`+iftime.time()-start_time<60:`
	`37`	`+continue`
	`38`	`+logging.error("job never succeeded")`
	`39`	`+forjobinproject.jobs.list():`
	`40`	`+job=project.jobs.get(job.id)`
	`41`	`+logging.info(f"{job.status} job:{job.pformat()}")`
	`42`	`+logging.info(f"job log:\n{job.trace()}\n")`
	`43`	`+pytest.fail("Fixture 'job_with_artifact' failed")`
`33`	`44`
`34`	`45`	`returnproject.jobs.get(jobs[0].id)`
`35`	`46`

Comments

(0)