Commit481bd4f

authored

Merge pull request#1039 from python-gitlab/fix/set-approvers

Fix/set approvers

2 parents47cb58c +adc9101 commit481bd4fCopy full SHA for 481bd4f

File tree

-3

lines changed

-3

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2762,12 +2762,13 @@ def set_approvers(`
`2762`	`2762`	`self._parent.get_id(),`
`2763`	`2763`	`)`
`2764`	`2764`	`data= {`
	`2765`	`+"name":"name",`
`2765`	`2766`	`"approvals_required":approvals_required,`
`2766`	`2767`	`"rule_type":"regular",`
`2767`	`2768`	`"user_ids":approver_ids,`
`2768`	`2769`	`"group_ids":approver_group_ids,`
`2769`	`2770`	`}`
`2770`		`-self.gitlab.http_put(path,post_data=data,**kwargs)`
	`2771`	`+self.gitlab.http_post(path,post_data=data,**kwargs)`
`2771`	`2772`
`2772`	`2773`
`2773`	`2774`	`classProjectMergeRequestAwardEmoji(ObjectDeleteMixin,RESTObject):`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,12 +56,12 @@ def end_log():`
`56`	`56`
`57`	`57`	`ars=project1.approvalrules.list(all=True)`
`58`	`58`	`assertlen(ars)==0`
`59`		`-project.approvalrules.create(`
	`59`	`+project1.approvalrules.create(`
`60`	`60`	`{"name":"approval-rule","approvals_required":1,"group_ids": [group1.id]}`
`61`	`61`	`)`
`62`	`62`	`ars=project1.approvalrules.list(all=True)`
`63`	`63`	`assertlen(ars)==1`
`64`		`-ars[0].approvals_required==2`
	`64`	`+assertars[0].approvals_required==2`
`65`	`65`	`ars[0].save()`
`66`	`66`	`ars=project1.approvalrules.list(all=True)`
`67`	`67`	`assertlen(ars)==1`

Comments

(0)