Commit3cda8ee

committed

fix(client): handle empty 204 reponses in PUT requests

1 parent70959e8 commit3cda8eeCopy full SHA for 3cda8ee

File tree

+17

-0

lines changed

+17

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1061,6 +1061,8 @@ def http_put(`
`1061`	`1061`	`raw=raw,`
`1062`	`1062`	`**kwargs,`
`1063`	`1063`	`)`
	`1064`	`+ifresult.status_codeingitlab.const.NO_JSON_RESPONSE_CODES:`
	`1065`	`+returnresult`
`1064`	`1066`	`try:`
`1065`	`1067`	`json_result=result.json()`
`1066`	`1068`	`ifTYPE_CHECKING:`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -766,6 +766,21 @@ def test_put_request_404(gl):`
`766`	`766`	`assertresponses.assert_call_count(url,1)isTrue`
`767`	`767`
`768`	`768`
	`769`	`+@responses.activate`
	`770`	`+deftest_patch_request_204(gl):`
	`771`	`+url="http://localhost/api/v4/projects"`
	`772`	`+responses.add(`
	`773`	`+method=responses.PUT,`
	`774`	`+url=url,`
	`775`	`+status=204,`
	`776`	`+match=helpers.MATCH_EMPTY_QUERY_PARAMS,`
	`777`	`+ )`
	`778`	`+`
	`779`	`+result=gl.http_put("/projects")`
	`780`	`+assertisinstance(result,requests.Response)`
	`781`	`+assertresponses.assert_call_count(url,1)isTrue`
	`782`	`+`
	`783`	`+`
`769`	`784`	`@responses.activate`
`770`	`785`	`deftest_put_request_invalid_data(gl):`
`771`	`786`	`url="http://localhost/api/v4/projects"`

Comments

(0)