Commit3984328

committed

chore: require kwargs forutils.copy_dict()

Non-keyword arguments are a tiny bit confusing as the destination isfirst and the source is second.

1 parent64d01ef commit3984328Copy full SHA for 3984328

File tree

-4

lines changed

-4

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -647,7 +647,7 @@ def http_request(`
`647`	`647`	`url=self._build_url(path)`
`648`	`648`
`649`	`649`	`params:Dict[str,Any]= {}`
`650`		`-utils.copy_dict(params,query_data)`
	`650`	`+utils.copy_dict(dest=params,src=query_data)`
`651`	`651`
`652`	`652`	`# Deal with kwargs: by default a user uses kwargs to send data to the`
`653`	`653`	`# gitlab server, but this generates problems (python keyword conflicts`
`@@ -656,12 +656,12 @@ def http_request(`
`656`	`656`	`# value as arguments for the gitlab server, and ignore the other`
`657`	`657`	`# arguments, except pagination ones (per_page and page)`
`658`	`658`	`if"query_parameters"inkwargs:`
`659`		`-utils.copy_dict(params,kwargs["query_parameters"])`
	`659`	`+utils.copy_dict(dest=params,src=kwargs["query_parameters"])`
`660`	`660`	`forargin ("per_page","page"):`
`661`	`661`	`ifarginkwargs:`
`662`	`662`	`params[arg]=kwargs[arg]`
`663`	`663`	`else:`
`664`		`-utils.copy_dict(params,kwargs)`
	`664`	`+utils.copy_dict(dest=params,src=kwargs)`
`665`	`665`
`666`	`666`	`opts=self._get_session_opts()`
`667`	`667`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ def response_content(`
`44`	`44`	`returnNone`
`45`	`45`
`46`	`46`
`47`		`-defcopy_dict(dest:Dict[str,Any],src:Dict[str,Any])->None:`
	`47`	`+defcopy_dict(*,dest:Dict[str,Any],src:Dict[str,Any])->None:`
`48`	`48`	`fork,vinsrc.items():`
`49`	`49`	`ifisinstance(v,dict):`
`50`	`50`	`# Transform dict values to new attributes. For example:`

Comments

(0)