NotificationsYou must be signed in to change notification settings
Fork674
Star2.4k

Commit3679591

authored

Merge pull request#1738 from python-gitlab/jlvillal/pylint_fixes

chore: fix pylint error "expression-not-assigned"

2 parents3a7d6f6 +a90eb23 commit3679591Copy full SHA for 3679591

File tree

2 files changed

+20

-29

lines changed

gitlab/v4
- cli.py
pyproject.toml

2 files changed

+20

-29

lines changed

`‎gitlab/v4/cli.py‎`

Lines changed: 20 additions & 28 deletions

Original file line number	Diff line number	Diff line change
`@@ -266,20 +266,16 @@ def _populate_sub_parser_by_class(`
`266`	`266`	`sub_parser_action.add_argument(f"--{id_attr}",required=True)`
`267`	`267`
`268`	`268`	`required,optional,dummy=cli.custom_actions[name][action_name]`
`269`		`- [`
`270`		`-sub_parser_action.add_argument(`
`271`		`-f"--{x.replace('_','-')}",required=True`
`272`		`- )`
`273`		`-forxinrequired`
`274`		`-ifx!=cls._id_attr`
`275`		`- ]`
`276`		`- [`
`277`		`-sub_parser_action.add_argument(`
`278`		`-f"--{x.replace('_','-')}",required=False`
`279`		`- )`
`280`		`-forxinoptional`
`281`		`-ifx!=cls._id_attr`
`282`		`- ]`
	`269`	`+forxinrequired:`
	`270`	`+ifx!=cls._id_attr:`
	`271`	`+sub_parser_action.add_argument(`
	`272`	`+f"--{x.replace('_','-')}",required=True`
	`273`	`+ )`
	`274`	`+forxinoptional:`
	`275`	`+ifx!=cls._id_attr:`
	`276`	`+sub_parser_action.add_argument(`
	`277`	`+f"--{x.replace('_','-')}",required=False`
	`278`	`+ )`
`283`	`279`
`284`	`280`	`ifmgr_cls.__name__incli.custom_actions:`
`285`	`281`	`name=mgr_cls.__name__`
`@@ -293,20 +289,16 @@ def _populate_sub_parser_by_class(`
`293`	`289`	`sub_parser_action.add_argument("--sudo",required=False)`
`294`	`290`
`295`	`291`	`required,optional,dummy=cli.custom_actions[name][action_name]`
`296`		`- [`
`297`		`-sub_parser_action.add_argument(`
`298`		`-f"--{x.replace('_','-')}",required=True`
`299`		`- )`
`300`		`-forxinrequired`
`301`		`-ifx!=cls._id_attr`
`302`		`- ]`
`303`		`- [`
`304`		`-sub_parser_action.add_argument(`
`305`		`-f"--{x.replace('_','-')}",required=False`
`306`		`- )`
`307`		`-forxinoptional`
`308`		`-ifx!=cls._id_attr`
`309`		`- ]`
	`292`	`+forxinrequired:`
	`293`	`+ifx!=cls._id_attr:`
	`294`	`+sub_parser_action.add_argument(`
	`295`	`+f"--{x.replace('_','-')}",required=True`
	`296`	`+ )`
	`297`	`+forxinoptional:`
	`298`	`+ifx!=cls._id_attr:`
	`299`	`+sub_parser_action.add_argument(`
	`300`	`+f"--{x.replace('_','-')}",required=False`
	`301`	`+ )`
`310`	`302`
`311`	`303`
`312`	`304`	`defextend_parser(parser:argparse.ArgumentParser)->argparse.ArgumentParser:`

`‎pyproject.toml‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,6 @@ disable = [`
`55`	`55`	`"consider-using-sys-exit",`
`56`	`56`	`"cyclic-import",`
`57`	`57`	`"duplicate-code",`
`58`		`-"expression-not-assigned",`
`59`	`58`	`"fixme",`
`60`	`59`	`"implicit-str-concat",`
`61`	`60`	`"import-outside-toplevel",`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3679591

File tree

2 files changed

2 files changed

`‎gitlab/v4/cli.py‎`

`‎pyproject.toml‎`

0 commit comments