Commit2cf12c7

Charles

committed

fix(docs and tests): update docs and tests for set_approvers

Updated the docs with the new set_approvers arguments, and updated tests with the arg as well.

1 parente512cdd commit2cf12c7Copy full SHA for 2cf12c7

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -56,5 +56,5 @@ Change project-level or MR-level MR allowed approvers::`
`56`	`56`	`project.approvals.set_approvers(approver_ids=[105],`
`57`	`57`	`approver_group_ids=[653, 654])`
`58`	`58`
`59`		`-mr.approvals.set_approvers(approver_ids=[105],`
	`59`	`+mr.approvals.set_approvers(approvals_required = 1,approver_ids=[105],`
`60`	`60`	`approver_group_ids=[653, 654])`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ def end_log():`
`37`	`37`	`approval.save()`
`38`	`38`	`approval=project1.approvals.get()`
`39`	`39`	`assertv!=approval.reset_approvals_on_push`
`40`		`-project1.approvals.set_approvers([1], [])`
	`40`	`+project1.approvals.set_approvers(1,[1], [])`
`41`	`41`	`approval=project1.approvals.get()`
`42`	`42`	`assertapproval.approvers[0]["user"]["id"]==1`
`43`	`43`
`@@ -50,7 +50,7 @@ def end_log():`
`50`	`50`	`approval.save()`
`51`	`51`	`approval=mr.approvals.get()`
`52`	`52`	`assertapproval.approvals_required==3`
`53`		`-mr.approvals.set_approvers([1], [])`
	`53`	`+mr.approvals.set_approvers(1,[1], [])`
`54`	`54`	`approval=mr.approvals.get()`
`55`	`55`	`assertapproval.approvers[0]["user"]["id"]==1`
`56`	`56`

Comments

(0)