Commit19573b4

committed

chore(test): prevent 'job_with_artifact' fixture running forever

Previously the 'job_with_artifact' fixture could run forever. Now giveit up to 60 seconds to complete before failing.

1 parent553f5b0 commit19573b4Copy full SHA for 19573b4

File tree

+12

-0

lines changed

+12

-0

lines changed

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,12 +24,24 @@`
`24`	`24`
`25`	`25`	`@pytest.fixture(scope="module")`
`26`	`26`	`defjob_with_artifacts(gitlab_runner,project):`
	`27`	`+start_time=time.time()`
	`28`	`+`
`27`	`29`	`project.files.create(data)`
`28`	`30`
`29`	`31`	`jobs=None`
`30`	`32`	`whilenotjobs:`
`31`	`33`	`time.sleep(0.5)`
`32`	`34`	`jobs=project.jobs.list(scope="success")`
	`35`	`+iftime.time()-start_time>60:`
	`36`	`+print("ERROR: job never succeeded")`
	`37`	`+forjobinproject.jobs.list():`
	`38`	`+job=project.jobs.get(job.id)`
	`39`	`+job.pprint()`
	`40`	`+ifjob.status=="failed":`
	`41`	`+print()`
	`42`	`+print("job log/trace:",job.trace())`
	`43`	`+print()`
	`44`	`+assertNone,"Fixture 'job_with_artifact' failed"`
`33`	`45`
`34`	`46`	`returnproject.jobs.get(jobs[0].id)`
`35`	`47`

Comments

(0)