NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

Commit115938b

committed

feat: add support for lists of integers to ListAttribute

Previously ListAttribute only support lists of integers. Now be moreflexible and support lists of items which can be coerced into strings,for example integers.This will help us fix issue#1407 by using ListAttribute for the'iids' field.

1 parente37de18 commit115938bCopy full SHA for 115938b

File tree

2 files changed

-1

lines changed

gitlab
- tests
  - test_types.py
- types.py

2 files changed

-1

lines changed

`‎gitlab/tests/test_types.py`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,11 @@ def test_list_attribute_get_for_api_from_list():`
`59`	`59`	`asserto.get_for_api()=="foo,bar,baz"`
`60`	`60`
`61`	`61`
	`62`	`+deftest_list_attribute_get_for_api_from_int_list():`
	`63`	`+o=types.ListAttribute([1,9,7])`
	`64`	`+asserto.get_for_api()=="1,9,7"`
	`65`	`+`
	`66`	`+`
`62`	`67`	`deftest_list_attribute_does_not_split_string():`
`63`	`68`	`o=types.ListAttribute("foo")`
`64`	`69`	`asserto.get_for_api()=="foo"`

`‎gitlab/types.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ def get_for_api(self):`
`42`	`42`	`ifisinstance(self._value,str):`
`43`	`43`	`returnself._value`
`44`	`44`
`45`		`-return",".join(self._value)`
	`45`	`+return",".join([str(x)forxinself._value])`
`46`	`46`
`47`	`47`
`48`	`48`	`classLowercaseStringAttribute(GitlabAttribute):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit115938b

File tree

2 files changed

2 files changed

`‎gitlab/tests/test_types.py`

`‎gitlab/types.py`

0 commit comments