Commit04c6063

authored

Merge pull request#2117 from python-gitlab/jlvillal/encodedid_path

fix: ensure path elements are escaped

2 parentsca3b438 +5d9c198 commit04c6063Copy full SHA for 04c6063

File tree

-5

lines changed

-5

lines changed

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -380,10 +380,12 @@ def _compute_path(self, path: Optional[str] = None) -> Optional[str]:`
`380`	`380`	`ifself._parentisNoneornotself._from_parent_attrs:`
`381`	`381`	`returnpath`
`382`	`382`
`383`		`-data= {`
`384`		`-self_attr:getattr(self._parent,parent_attr,None)`
`385`		`-forself_attr,parent_attrinself._from_parent_attrs.items()`
`386`		`- }`
	`383`	`+data:Dict[str,Optional[gitlab.utils.EncodedId]]= {}`
	`384`	`+forself_attr,parent_attrinself._from_parent_attrs.items():`
	`385`	`+ifnothasattr(self._parent,parent_attr):`
	`386`	`+data[self_attr]=None`
	`387`	`+continue`
	`388`	`+data[self_attr]=gitlab.utils.EncodedId(getattr(self._parent,parent_attr))`
`387`	`389`	`self._parent_attrs=data`
`388`	`390`	`returnpath.format(**data)`
`389`	`391`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -391,7 +391,7 @@ def project_file(project):`
`391`	`391`	`@pytest.fixture(scope="function")`
`392`	`392`	`defrelease(project,project_file):`
`393`	`393`	`_id=uuid.uuid4().hex`
`394`		`-name=f"test-release-{_id}"`
	`394`	`+name=f"we_have_a_slash/test-release-{_id}"`
`395`	`395`
`396`	`396`	`project.refresh()# Gets us the current default branch`
`397`	`397`	`release=project.releases.create(`

Comments

(0)