- Notifications
You must be signed in to change notification settings - Fork3
Convertsetup.py
topyproject.toml
#5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
egeakman merged 3 commits intopython-docs-translations:masterfromhugovk:setup.py-to-pyproject.tomlNov 8, 2023
Merged
Convertsetup.py
topyproject.toml
#5
egeakman merged 3 commits intopython-docs-translations:masterfromhugovk:setup.py-to-pyproject.tomlNov 8, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thanks Hugo! |
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
egeakman approved these changesNov 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#4.
I used two tools for this:
I used the first to convert
setup.py
tosetup.cfg
, and the second fromsetup.cfg
topyproject.toml
, something like this:Next, I added a few more pre-commit hooks, one to format
pyproject.toml
to make it easy to compare against other projects, and some others to check TOML and YAML files.Then to check the output is okay, I ran:
Which creates an sdist and wheel in the
dist
directory. I compared the output frommaster
and from this branch, and there were no unexpected differences.We're still using setuptools here as the "build backend", which is just fine. We can also easily change it to others too. I tend to use hatchling, but it doesn't make too much difference.