Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replace black and isort with ruff#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
egeakman merged 1 commit intomainfromruff
Jun 7, 2025
Merged

Replace black and isort with ruff#23

egeakman merged 1 commit intomainfromruff
Jun 7, 2025

Conversation

egeakman
Copy link
Member

Closes#21

@egeakmanegeakman self-assigned thisJun 2, 2025
@egeakmanegeakman merged commitbf0b8ea intomainJun 7, 2025
56 checks passed
@egeakmanegeakman deleted the ruff branchJune 7, 2025 19:48
Copy link
Contributor

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Post-merge review (I was travelling last week): looks good :)

Only suggestions I would have made:

  • keep check-toml
  • put ruff-pre-commit first (because it might fix some things so pre-commit-hooks doesn't need to complain about them, and see the note athttps://github.com/astral-sh/ruff-pre-commit about putting it before other formatters when using--fix
  • move the Ruff args out of pre-commit config and intopyproject.toml, so they are available when running Ruff outside of pre-commit

But not a big deal.

egeakman reacted with heart emoji
@egeakman
Copy link
MemberAuthor

egeakman commentedJun 8, 2025
edited
Loading

Post-merge review (I was travelling last week): looks good :)

Only suggestions I would have made:

  • keep check-toml
  • put ruff-pre-commit first (because it might fix some things so pre-commit-hooks doesn't need to complain about them, and see the note athttps://github.com/astral-sh/ruff-pre-commit about putting it before other formatters when using--fix
  • move the Ruff args out of pre-commit config and intopyproject.toml, so they are available when running Ruff outside of pre-commit

But not a big deal.

Thank you! Created a new issue (#24) to track these!

hugovk reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk left review comments

@rffontenellerffontenelleAwaiting requested review from rffontenelle

Assignees

@egeakmanegeakman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replaceblack andisort withruff
2 participants
@egeakman@hugovk

[8]ページ先頭

©2009-2025 Movatter.jp