- Notifications
You must be signed in to change notification settings - Fork3
Replace black and isort with ruff#23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
bf0b8ea
intomainUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Post-merge review (I was travelling last week): looks good :)
Only suggestions I would have made:
- keep check-toml
- put ruff-pre-commit first (because it might fix some things so pre-commit-hooks doesn't need to complain about them, and see the note athttps://github.com/astral-sh/ruff-pre-commit about putting it before other formatters when using
--fix
- move the Ruff args out of pre-commit config and into
pyproject.toml
, so they are available when running Ruff outside of pre-commit
But not a big deal.
egeakman commentedJun 8, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you! Created a new issue (#24) to track these! |
Closes#21