It wasn't the actual problem there, withcontrol.matlab.wrappers.rlocus not being called (rathercontrol.rlocus.rlocus = control.rlocus.root_locus_plot), but still this does forward kwargs to that function which is expectinggains rather thanklist orkvect (though it does have acontrol._process_legacy_keyword in place to catch the latter).

Feel free to ignore or use this.

klist->gainspython-control#998

c5e2639

slivingston self-assigned this

May 10, 2024

DOC: update keywords of matlab.wrappers.rlocus

cb4244d

Copy link

Member

slivingston commentedMay 10, 2024

Thanks,@gdmcbain ! While reviewing this, I noticed anotherkvect in the same docstring, so I fixed it, too.

By the way, it looks like the email address you are using in the commit is not associated with your GitHub account because your commit appears without an avatar above. Is that intentional, or did you want to use a different address?

slivingston approved these changes

May 10, 2024

View reviewed changes

Copy link

coveralls commentedMay 10, 2024

coverage: 94.503%. remained the same
when pullingcb4244d on gdmcbain:998-matlab-rlocus-klist
intoe4a03e8 on python-control:main.

Copy link

Contributor

bnavigator commentedMay 11, 2024

How about mapping MATLAB's parameterk to thegains kwarg ofroot_locus_plot()?https://www.mathworks.com/help/control/ref/dynamicsystem.rlocus.html

murrayrm merged commit2d1f514 intopython-control:main

May 11, 2024

gdmcbain deleted the 998-matlab-rlocus-klist branch

May 13, 2024 01:30

gdmcbain added a commit to gdmcbain/python-control that referenced this pull request

May 13, 2024

process legacy keyword k->gainspython-control#999

206ca85

Copy link

ContributorAuthor

gdmcbain commentedMay 13, 2024

By the way, it looks like the email address you are using in the commit is not associated with your GitHub account because your commit appears without an avatar above. Is that intentional, or did you want to use a different address?

Oops. I assume it's too late to fix now; never mind.

How about mapping MATLAB's parameterk to thegains kwarg ofroot_locus_plot()?https://www.mathworks.com/help/control/ref/dynamicsystem.rlocus.html

Sure, why not. Let's.