- Notifications
You must be signed in to change notification settings - Fork441
Add extra information to nyquist plots#997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
It would be nice to have unit tests, even if they call the code to get coverage (better would be to check to make sure the lines are in the right place). If the system is discrete time, are these still the right circles to draw? Any interaction with axis scaling? Eg, if all of the action is very near the origin, might this reset the axes in a way that makes it harder to see the Nyquist plot? If so, is there a better way to do that (eg, fix the axes and let the circle disappear at the edges of the axes)? |
coveralls commentedApr 26, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This works as well for discrete systems. And tests have now been added. |
control/freqplot.py Outdated
| If 'True', displays the unit circle, to read gain crossover frequency. | ||
| mt_circles : array_like, optional | ||
| draws circles corresponding to the given magnitudes of sensitivity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For consistency, start phrase with a capital letter and end in a period.
control/freqplot.py Outdated
| draws circles corresponding to the given magnitudes of sensitivity | ||
| ms_circles : array_like, optional | ||
| draws circles corresponding to the given magnitudes in complementary sensitivity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For consistency, start phrase with a capital letter and end in a period.
I rebased this onto the current main branch and added the ability to set the line style for the circles using |
4acc78b intopython-control:mainUh oh!
There was an error while loading.Please reload this page.
Adds the possibility to add the unit circle (to get gain crossover frequency), Ms-circle (sensitivity) and Mt-circle (complementary sensitivity) to nyquist plots similar to the approach taken inJuliaControl