Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix nyquist plotting from FrequencyResponseData#996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
murrayrm merged 3 commits intopython-control:mainfromwueestry:nyquist_frd
Jun 8, 2024

Conversation

wueestry
Copy link
Contributor

This PR resolves the issue#992, by adding a check for FrequencyResponseData during plotting of a nyquist plot and setting omega if not yet set correctly

@coveralls
Copy link

coveralls commentedApr 26, 2024
edited
Loading

Coverage Status

coverage: 94.497% (-0.007%) from 94.504%
when pulling7fa5960 on wueestry:nyquist_frd
intoe1d21d2 on python-control:main.

@murrayrm
Copy link
Member

This is a good fix, but I think we could add a bit better support if there are multiple FRD systems with different frequencies and not explicit frequency list given. For example, try this:

import control as ctsys = ct.rss(4, 1, 1)sys1 = ct.frequency_response(sys, np.logspace(-1, 1, 10))sys2 = ct.frequency_response(sys, np.logspace(-2, 2, 10))ct.bode_plot([sys1, sys2])                     # works OKct.nyquist_plot(sys1, np.logspace(-1, 1, 10))  # works OKct.nyquist_plot(sys2, np.logspace(-1, 1, 10))  # generates error (as it should)ct.nyquist_plot([sys1, sys2])                  # generates error (does it need to?)

It seems to me that the last case should work OK and just plot each system independently, without needing a common frequency range (as it does for Bode plots).

@murrayrmmurrayrm merged commitdbc998d intopython-control:mainJun 8, 2024
23 checks passed
@murrayrmmurrayrm added this to the0.10.1 milestoneJun 30, 2024
@murrayrmmurrayrm mentioned this pull requestJun 30, 2024
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.

3 participants
@wueestry@coveralls@murrayrm

[8]ページ先頭

©2009-2025 Movatter.jp