- Notifications
You must be signed in to change notification settings - Fork441
Fix nyquist plotting from FrequencyResponseData#996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedApr 26, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This is a good fix, but I think we could add a bit better support if there are multiple FRD systems with different frequencies and not explicit frequency list given. For example, try this:
It seems to me that the last case should work OK and just plot each system independently, without needing a common frequency range (as it does for Bode plots). |
dbc998d
intopython-control:mainUh oh!
There was an error while loading.Please reload this page.
This PR resolves the issue#992, by adding a check for FrequencyResponseData during plotting of a nyquist plot and setting omega if not yet set correctly