Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update documentation, processing of root_locus kvect keyword#989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

murrayrm
Copy link
Member

This PR addresses issue#987, which was partially fixed in#988, by consistently using the keywordgains instead ofkvect in the root locus commands. In addition, if thekvect keyword is used, a warning is generated indicating thatkvect has been deprecated andgains should be used instead.

Also include some minor reformatting of docstrings in rlocus.py.

@coveralls
Copy link

coveralls commentedApr 5, 2024•
edited
Loading

Coverage Status

coverage: 94.482%. remained the same
when pulling1b59bd6 on murrayrm:update_rlocus_kvect-04Apr2024
intoc638362 on python-control:main.

kvect keyword argument if provided).
(legacy) If the `plot` keyword is given, returns the closed-loop
root locations, arranged such that each row corresponds to a gain
in gains, and the array of gains (ame as gains keyword argument if
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
ingains,andthearrayofgains (ameasgainskeywordargumentif
ingains,andthearrayofgains (sameas`gains`keywordargumentif

Copy link
Member

@slivingstonslivingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is good to merge, except for the misprint identified by@bnavigator (the misprint existed before this PR, but might as well fix it).

@murrayrmmurrayrm merged commit49f03e7 intopython-control:mainApr 6, 2024
@murrayrmmurrayrm added this to the0.10.1 milestoneJun 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bnavigatorbnavigatorbnavigator left review comments

@slivingstonslivingstonslivingston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.

4 participants
@murrayrm@coveralls@slivingston@bnavigator
[8]ページ先頭
©2009-2025 Movatter.jp