- Notifications
You must be signed in to change notification settings - Fork441
Do not overwrite np = numpy with an array size.#98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The function failed to be called with python3
coveralls commentedJun 23, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I would not expect this to only affect Python 3. |
Can you provide an example that demonstrates the error? Since |
Hum, I don't remember: it was some time ago. Comparing to other modules, t should be call _np I think instead of what I wrote. Anyway: as it's a small fix, without huge repercussions, I think it should be somehow done. Even if you don't use my PR, just do the correction somehow? |
I fixed this on#100. Itis a bug; if, on that branch, I revert from np_ to np, I get the error below. I'd have to read up on how Python handles globals and locals to explain this (did that change in Python 3?).
|
Ok, then maybe merging#100 would be better than mine. |
Changes from pull request#100 were merged, which subsumes changes from here,as noted above. In particular, cf. lines93 and157 of control/robust.py as of commitd4e0155 (current tip of @ochurlaud Nonetheless, thanks for this pull request. I should have been faster to review it. |
The function failed to be called with python3