Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

remove np.int#978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

AbhiramShenoiKodiak

Innumpy versions >1.24 the usage ofnp.int has been deprecated. This is the only file that uses this.

This PR makes a change to allowpython-control to be compatible withnumpy > 1.24.

https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

@bnavigator
Copy link
Contributor

Thanks, but this is unused old code. This should be "fixed" when actually merged into python-control or be removed.

An thoughts@robertobucher,@murrayrm?

@bnavigator
Copy link
Contributor

Also, if we fix it, Plainint instead ofnp.int64 should be used.

@coveralls
Copy link

Coverage Status

coverage: 94.422%. remained the same
when pulling429a5a0 on AbhiramShenoiKodiak:patch-1
into7a70be1 on python-control:main.

@murrayrm
Copy link
Member

I think we can probably remove theexternal/ directory. It was there from a time when we were missing some code and I thought people might want to see other implementations. We don't actively use it and it is probably mostly out of date.

I'll post a short PR to remove it and close out this PR.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@AbhiramShenoiKodiak@bnavigator@coveralls@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp