Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

norm added to the sphinx documentation#976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

henriks76
Copy link

Addednorm to the function reference in the sphinx documentation under Utility functions and conversions.

See#971

@coveralls
Copy link

coveralls commentedMar 3, 2024•
edited
Loading

Coverage Status

coverage: 94.422%. remained the same
when pulling6828c67 on henriks76:system-norms-doc
intoe1e33e4 on python-control:main.

@bnavigator
Copy link
Contributor

**********************************************************************File "../control/sysnorm.py", line ?, in defaultFailed example:    ct.norm(Gc, 'inf', tol=1e-11, method='scipy')Expected:    1.000000000007276Got:    0.999999999992724*********************************************************************

Copy link
Contributor

@bnavigatorbnavigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Need to fix the tolerance in the docstring example

@bnavigator
Copy link
Contributor

bnavigator commentedMar 4, 2024•
edited
Loading

Document: generated/control.norm--------------------------------**********************************************************************File "../control/sysnorm.py", line ?, in defaultFailed example:    ct.norm(Gc, 'inf', tol=1e-4, method='scipy')Expected:    1.00006103515625Got:    0.99993896484375**********************************************************************1 items had failures:   1 of   3 in default3 tests in 1 items.2 passed and 1 failed.***Test Failed*** 1 failures.

You won't get any futher by setting the example to 0.99993896484375. Different platform yield different values. Probably best to round the output:

https://docs.python.org/3/library/doctest.html#warnings

@bnavigator
Copy link
Contributor

@henriks76
Copy link
Author

OK will use rounding this time.

…der Utility functions and conversions* Use round in the docstring examples
Copy link
Contributor

@bnavigatorbnavigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

KybernetikJo reacted with hooray emoji
@bnavigatorbnavigator merged commit7a70be1 intopython-control:mainMar 5, 2024
@henriks76henriks76 deleted the system-norms-doc branchMarch 5, 2024 09:47
@murrayrmmurrayrm added this to the0.10.0 milestoneMar 31, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bnavigatorbnavigatorbnavigator approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

4 participants
@henriks76@coveralls@bnavigator@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp