- Notifications
You must be signed in to change notification settings - Fork441
Fix CI warnings#955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix CI warnings#955
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedDec 30, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Either this or the other way round. Python 3.12 requires numpy 1.26 on conda, already triggering the deprecation warnings. I had to disable them for the Slycot CI:https://github.com/python-control/Slycot/pull/227/files#diff-b2cf1d5b6cad7a0f6a749da416cb8a4e34040b2164a84a651783692d4b60d608R17 |
Looks like there were no conflicts, so going ahead and merging. @bnavigator: FYI (and not really for this PR), I tried updating GitHub actions to use Python 3.12 but mamba caused problems, so I'm waiting until that clears. You can find the attempthere. |
Uh oh!
There was an error while loading.Please reload this page.
This PR makes a bunch of small changes to remove warning messages in the GitHub actions CI runs:
item()
(old usage is newly deprecated in NumPy).set_tight_layout(True)
tofig.set_layout_engine('tight')
(newly deprecated in Matplotlib).connect
(which are OK for now).Note: it is likely that this PR will conflict with#953. We should probably merge#953 first and then rebase this PR since the changes here are pretty straightforward.