Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix CI warnings#955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
murrayrm merged 4 commits intopython-control:mainfrommurrayrm:fixwarnings-23Dec2023
Jan 12, 2024
Merged

Conversation

murrayrm
Copy link
Member

@murrayrmmurrayrm commentedDec 29, 2023
edited
Loading

This PR makes a bunch of small changes to remove warning messages in the GitHub actions CI runs:

  • Access scalar NumPy arrays usingitem() (old usage is newly deprecated in NumPy).
  • Changeset_tight_layout(True) tofig.set_layout_engine('tight') (newly deprecated in Matplotlib).
  • Update unit tests using deprecated functionality to use current functionality.
  • Add warning filters for internal calls toconnect (which are OK for now).
  • Avoid calling tf2zpk with zero in the numerator (SciPy generates warning).
  • Fix up some strings that had newly deprecated escape sequences (by using raw strings)
  • Turn off warnings for optimal control problems that fail to hit desired precision (but still return valid answers)

Note: it is likely that this PR will conflict with#953. We should probably merge#953 first and then rebase this PR since the changes here are pretty straightforward.

@coveralls
Copy link

coveralls commentedDec 30, 2023
edited
Loading

Coverage Status

coverage: 94.78% (-0.09%) from 94.866%
when pullingdc74493 on murrayrm:fixwarnings-23Dec2023
intoeb0f3f9 on python-control:main.

@murrayrmmurrayrm added this to the0.10.0 milestoneDec 30, 2023
@bnavigator
Copy link
Contributor

Note: it is likely that this PR will conflict with#953. We should probably merge#953 first and then rebase this PR since the changes here are pretty straightforward.

Either this or the other way round. Python 3.12 requires numpy 1.26 on conda, already triggering the deprecation warnings. I had to disable them for the Slycot CI:https://github.com/python-control/Slycot/pull/227/files#diff-b2cf1d5b6cad7a0f6a749da416cb8a4e34040b2164a84a651783692d4b60d608R17

@murrayrm
Copy link
MemberAuthor

Looks like there were no conflicts, so going ahead and merging.

@bnavigator: FYI (and not really for this PR), I tried updating GitHub actions to use Python 3.12 but mamba caused problems, so I'm waiting until that clears. You can find the attempthere.

bnavigator reacted with thumbs up emoji

@murrayrmmurrayrm reopened thisJan 12, 2024
@murrayrmmurrayrm merged commit9509dfd intopython-control:mainJan 12, 2024
@murrayrmmurrayrm deleted the fixwarnings-23Dec2023 branchJanuary 12, 2024 05:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@slivingstonslivingstonslivingston left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

4 participants
@murrayrm@coveralls@bnavigator@slivingston

[8]ページ先頭

©2009-2025 Movatter.jp