Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix up some warning messages due to converted systems#907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

murrayrm
Copy link
Member

Small PR to fix up some issues where the functionality in#903 was causing some warning messages. In particular, the following snipped was causing a warning (frommatlab_test.py):

siso_tf2 = tf([1, 1], [1, 2, 3, 1])siso_ss2 = ss(siso_tf2)[gm, pm, gmc, pmc] = margin(siso_ss2 * siso_ss2 * 2)

The reason for the warning was thatsiso_ss2 had the name 'sys[0]$converted' and when you create an interconnected system with duplicated non-generic names it gives you a warning (since things like change the parameters of one of the systems would affect the other.

To fix this, converted LinearIOSystems with "generic" names (sys[0]) donot get '$converted' added to the end. Instead they just get a new generic system name.

That change meant that some of the previous unit tests needed to use an explicitly named system, which is what the the changes in the unit tests are about.

@murrayrmmurrayrm added this to the0.9.4 milestoneJun 8, 2023
@coveralls
Copy link

Coverage Status

coverage: 94.628%. remained the same when pullingfb7a4a5 on murrayrm:fix_warnings-07Jun2023 intod834f7a on python-control:main.

@murrayrmmurrayrm merged commit56b9402 intopython-control:mainJun 9, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.4
Development

Successfully merging this pull request may close these issues.

2 participants
@murrayrm@coveralls

[8]ページ先頭

©2009-2025 Movatter.jp