NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

Fix root_locus() handling of ax parameter#871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sawyerbfuller merged 1 commit intopython-control:mainfromhenklaak:fix_root_locus_ax

Feb 23, 2023

Merged

Fix root_locus() handling of ax parameter#871

sawyerbfuller merged 1 commit intopython-control:mainfromhenklaak:fix_root_locus_ax

Feb 23, 2023

Conversation

Copy link

Contributor

henklaak commentedFeb 22, 2023

Fixes#870

Fix root_locus() handling of ax parameter

d13f1ed

Copy link

coveralls commentedFeb 22, 2023

Coverage: 94.883% (+0.01%) from 94.872% when pullingd13f1ed on henklaak:fix_root_locus_ax into346bc40 on python-control:main.

Copy link

Contributor

sawyerbfuller commentedFeb 22, 2023

This seems like a more straightforward and correct way of implementing sgrid - can you confirmsisotool still works as you might expect on that transfer function, and that the gridlines turn off whenrlocus_grid=False?

Also, we currently have an excess of sgrid functions. There is another : ) It is to be found ingrid.py and it is calledsgrid. I haven't compared the two but that one may be more modern/faster? (though it also needs to be upgraded to accept an ax keyword). If so, maybe theroot_locus function should switch to using that one and delete the one inrlocus.