Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Small fixes based on Caltech CDS 112 course#849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
murrayrm merged 12 commits intopython-control:mainfrommurrayrm:cds112_fixes-12Jan2023
Mar 24, 2023

Conversation

murrayrm
Copy link
Member

@murrayrmmurrayrm commentedJan 14, 2023•
edited
Loading

This PR contains some small fixes that I discovered while teaching CDS 112 at Caltech in Winter 2023:

  • Fixed bug increate_statefbk_iosystem that didn't proper handle 1D gain schedules.
  • flatsys.point_to_point generates an error if you specify a cost or constraint with less than 3 time points.
  • Sampling aLinearIOSystem returns aLinearIOSystem (before it returned aStateSpace system).
  • Added anadd_unused keyword parameter tointerconnect that allows unused inputs or outputs to be added as inputs or outputs of the interconnected system (useful for doing a "partial" interconnection).
  • create_mpc_iosystem now allows system and signal names to be specified via appropriate keywords.
  • Changedtype keyword forcreate_statefbk_iosystem tocontroller_type (linear or nonlinear). Usingtype generates a deprecation warning.
  • Addedcontrol_indices andstate_indices tocreate_statefbk_iosystem to allow partial interconnection (eg, for inner/outer loop construction).
  • Updated unit tests, docstrings, and comments.

@coveralls
Copy link

Coverage Status

Coverage: ?%. Remained the same when pulling10bcd65 on murrayrm:cds112_fixes-12Jan2023 into55730b6 on python-control:main.

@coveralls
Copy link

coveralls commentedJan 14, 2023•
edited
Loading

Coverage Status

Coverage: 94.876% (-0.007%) from 94.883% when pulling574cf69 on murrayrm:cds112_fixes-12Jan2023 into08dcc95 on python-control:main.

type : 'linear' or 'nonlinear', optional
controller_type : 'linear' or 'nonlinear', optional
Copy link
Contributor

@bnavigatorbnavigatorJan 15, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's an API change. The milestone should be 0.10.0 (or 1.0.0) then.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I put in code to handle legacy calls, sotype will still work. See line 732.

@bnavigator
Copy link
Contributor

Rebased onto current main, in order to resolve conflicts due to#857

@murrayrmmurrayrm marked this pull request as ready for reviewMarch 13, 2023 05:55
@murrayrmmurrayrmforce-pushed thecds112_fixes-12Jan2023 branch from49756c4 to574cf69CompareMarch 18, 2023 17:33
@murrayrmmurrayrm merged commit177cba9 intopython-control:mainMar 24, 2023
@murrayrmmurrayrm deleted the cds112_fixes-12Jan2023 branchMarch 24, 2023 04:28
@murrayrmmurrayrm added this to the0.9.4 milestoneMar 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bnavigatorbnavigatorbnavigator left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.4
Development

Successfully merging this pull request may close these issues.

create_statefbk_iosystem sets system name incorrectly The step_info() function is not documented on readthedocs
3 participants
@murrayrm@coveralls@bnavigator
[8]ページ先頭
©2009-2025 Movatter.jp